Bay 12 Games Forum

Dwarf Fortress => DF Modding => Topic started by: Bohandas on March 30, 2011, 10:37:56 am

Title: Plant-based glazes... Why isn't this working?
Post by: Bohandas on March 30, 2011, 10:37:56 am
Ok, so I put together some custom plants with the intent of being able to use the products from said plants as glazes, but the game doesn't seem to recognize the plant products as potential glazes. I'm posting the raws and have bolded the relevant sections, can any of you figure out what I did wrong?

Spoiler: Comedy Stick (click to show/hide)

Spoiler: Volcano Root (click to show/hide)

Spoiler: depreciated old versions of plants (click to show/hide)

Edit: Tried to fix the problem with some custom reactions, which also isn't working

Spoiler: Custom Reactions (click to show/hide)
Title: Re: Plant-based glazes... Why isn't this working?
Post by: Quietust on March 30, 2011, 11:21:13 am
They don't work because the glazing reactions only accept raw materials not stored in containers - in order to even consider them, you'll need to modify the existing glaze reactions to accept objects stored in containers (ideally POWDER_MISC:NONE objects stored in BOX:NONE containers with the [BAG] property), then add new reactions (likely at a quern/millstone) to grind ash/cassiterite into glaze powder.

There's also the issue that "magma lacquer" is a liquid at room temperature, stored in a vial. Even if you added additional reactions to accept liquid glazes, I'm not sure the glaze would actually be applied successfully.
Title: Re: Plant-based glazes... Why isn't this working?
Post by: NW_Kohaku on March 30, 2011, 11:28:09 am
Just to briefly go into a technical derail - lacquer is different from a glaze - you put plant-based dies in a kiln and fire it to 1000 degrees, you will reduce the dyes to ash.  Glazes are metals that won't burn.  Lacquer is more like conventional paint.  (And I've been meaning to work on something like a lacquerware mod for a while, now...)
Title: Re: Plant-based glazes... Why isn't this working?
Post by: Bohandas on March 30, 2011, 11:40:54 am
Quote from: Quietust on March 30, 2011, 11:21:13 am
There's also the issue that "magma lacquer" is a liquid at room temperature, stored in a vial. Even if you added additional reactions to accept liquid glazes, I'm not sure the glaze would actually be applied successfully.

The "Raw Magma Lacquer" is a liquid, the actual "Magma Lacquer" defined immediately below is functionally identical to the default glaze materials.
Title: Re: Plant-based glazes... Why isn't this working?
Post by: NW_Kohaku on March 30, 2011, 11:57:49 am
Shouldn't you be defining the lacquer as a glaze material in the body of the code where you are defining the mill product, rather than the whole plant?
Title: Re: Plant-based glazes... Why isn't this working?
Post by: Bohandas on April 03, 2011, 11:48:18 am
Quote from: NW_Kohaku on March 30, 2011, 11:57:49 am
Shouldn't you be defining the lacquer as a glaze material in the body of the code where you are defining the mill product, rather than the whole plant?

I'm not sure I understand what you mean by that.
Title: Re: Plant-based glazes... Why isn't this working?
Post by: Bohandas on April 03, 2011, 01:54:44 pm
Will this custom reaction work?
(Given that I've changed the GLAZE_MATs in the custom plants to LACQUER_MAT)

[REACTION:LACQUER_LARGE_POT]
   [NAME:lacquer large clay/stone pot]
   [BUILDING:KILN:CUSTOM_ALT_Q]
   [REAGENT:glaze:1:NONE:NONE:NONE:NONE]
      [HAS_MATERIAL_REACTION_PRODUCT:LACQUER_MAT]
   [REAGENT:large pot:1:TOOL:ITEM_TOOL_LARGE_POT:NONE:NONE]
      [REACTION_CLASS:CAN_GLAZE]
      [EMPTY]
      [NOT_IMPROVED]
      [PRESERVE_REAGENT]
   [IMPROVEMENT:100:large pot:GLAZED:GET_MATERIAL_FROM_REAGENT:glaze:LACQUER_MAT]
   [SKILL:GLAZING]
Title: Re: Plant-based glazes... Why isn't this working?
Post by: Grimlocke on April 03, 2011, 02:18:36 pm
You may need to include a container for the laquer.
Title: Re: Plant-based glazes... Why isn't this working?
Post by: Bohandas on April 03, 2011, 02:30:49 pm
Quote from: Grimlocke on April 03, 2011, 02:18:36 pm
You may need to include a container for the laquer.

Is there any way to do thatn in such a way as to include both the magma lacauer (which is stored in a flask) and the laughing lacquer (which is stored in a bag)?

Would...   
[REAGENT:container:1:NONE:NONE:NONE:NONE]
      [CONTAINS_REAGENT:glaze]
      [PRESERVE_REAGENT]
Work?
Title: Re: Plant-based glazes... Why isn't this working?
Post by: Bohandas on April 04, 2011, 09:09:52 pm
Ok, so I tried to fix the problem with some custom reactions but they're not working. What's wrong?


Spoiler: Comedy Stick (click to show/hide)

Spoiler: Volcano Root (click to show/hide)

Spoiler: Custom Reactions (click to show/hide)
[/quote]
Title: Re: Plant-based glazes... Why isn't this working?
Post by: Bohandas on April 04, 2011, 09:20:03 pm
Changed those custom reactions I mentioned in my last post so that they mention the container the reagent is in, but it still doesn't work.

Spoiler: Tweaked versions of new reactions (click to show/hide)

Next I'm gonna try tweaking the order in which the reagents are specified. Maybe that'll work. Wish me luck.
Title: Re: Plant-based glazes... Why isn't this working?
Post by: Bohandas on April 04, 2011, 09:59:48 pm
OK, with this version of the reaction, the task is being performed, but its not doing anything:

Spoiler: Lacquering reactions v4 (click to show/hide)
Title: Re: Plant-based glazes... Why isn't this working?
Post by: Bohandas on April 04, 2011, 10:30:58 pm
Quote from: Bohandas on April 04, 2011, 09:59:48 pm
OK, with this version of the reaction, the task is being performed, but its not doing anything:

Spoiler: Lacquering reactions v4 (click to show/hide)

additionally, it seems to be ignoring the first two reagents entirely...
Title: Re: Plant-based glazes... Why isn't this working?
Post by: Bohandas on April 04, 2011, 10:35:52 pm
OK, found an error with the container, I left out the number of reagents. Now its back to not letting me perform the reaction:


Spoiler: custom reactions version 5 (click to show/hide)
Title: Re: Plant-based glazes... Why isn't this working?
Post by: Bohandas on April 05, 2011, 11:33:47 am
Do you think that it would help to move the actual lacquers/glazes to an "inorganic_..." file?

Or to make the reaction reagents more specific?
Title: Re: Plant-based glazes... Why isn't this working?
Post by: Bohandas on April 05, 2011, 05:25:33 pm
Quote from: Bohandas on April 05, 2011, 11:33:47 am
Or to make the reaction reagents more specific?

And if I did this, is there any way to do it without needing seperate reactions for the magma glaze and laughing lacquer?
Title: Re: Plant-based glazes... Why isn't this working?
Post by: Bohandas on April 05, 2011, 06:53:27 pm
Quote from: Bohandas on April 05, 2011, 05:25:33 pm
Quote from: Bohandas on April 05, 2011, 11:33:47 am
Or to make the reaction reagents more specific?

And if I did this, is there any way to do it without needing seperate reactions for the magma glaze and laughing lacquer?

Well, I edited the reaction and tried to specifically target the laughing lacquer powder, and it didn't work...

Spoiler: another failed version of the custom reaction (click to show/hide)

Is it maybe possible that there's just some kind of stupid-ass typo in there somewhere that I'm not noticing thats keeping the reaction from recognizing the custom plant materials as valid reagents?????
Title: Re: Plant-based glazes... Why isn't this working?
Post by: Bohandas on April 06, 2011, 11:45:38 am
Quote from: Bohandas on April 05, 2011, 06:53:27 pm
Quote from: Bohandas on April 05, 2011, 05:25:33 pm
Quote from: Bohandas on April 05, 2011, 11:33:47 am
Or to make the reaction reagents more specific?

And if I did this, is there any way to do it without needing seperate reactions for the magma glaze and laughing lacquer?

Well, I edited the reaction and tried to specifically target the laughing lacquer powder, and it didn't work...

Spoiler: another failed version of the custom reaction (click to show/hide)

Do you think it would help if I added the [BAG] token to the container reagent?
Title: Re: Plant-based glazes... Why isn't this working?
Post by: Bohandas on April 07, 2011, 11:49:49 am
Seriously? Nobody has any other insights?
Title: Aha! Got It Working!
Post by: Bohandas on April 08, 2011, 12:20:40 pm
Ha ha! I've got it working!

Spoiler: Reactions (click to show/hide)

Spoiler: plants (click to show/hide)

(Technically I only currently have comfirmation that the comedy stick laughing lacquer actually works, but at least I know I've got it working)
Title: Re: Plant-based glazes... Why isn't this working?
Post by: Bohandas on April 10, 2011, 01:39:44 pm
Quote from: Bohandas on April 08, 2011, 12:20:40 pm
Ha ha! I've got it working!

Spoiler: Reactions (click to show/hide)

Spoiler: plants (click to show/hide)

(Technically I only currently have comfirmation that the comedy stick laughing lacquer actually works, but at least I know I've got it working)

Ok, this is weird, I put this into another world, and now its stopped working again.
Title: Re: Plant-based glazes... Why isn't this working?
Post by: Grimlocke on April 10, 2011, 02:12:30 pm
Seems the rest of the forums are as stumped as I am. Cant see anything wrong there, perhaps you have ran into a bug?

Only thing I can think of is that improvements with plant mats are botched somehow, but the only way to be sure is to take away reagent condition untill it works, and then stacking them back again untill it fails again.
Title: Re: Plant-based glazes... Why isn't this working?
Post by: NW_Kohaku on April 10, 2011, 05:55:25 pm
Quote from: Bohandas on April 10, 2011, 01:39:44 pm
Quote from: Bohandas on April 08, 2011, 12:20:40 pm
Ha ha! I've got it working!

Spoiler: Reactions (click to show/hide)

Spoiler: plants (click to show/hide)

(Technically I only currently have comfirmation that the comedy stick laughing lacquer actually works, but at least I know I've got it working)

Ok, this is weird, I put this into another world, and now its stopped working again.

Are you sure you didn't change the raws inside the save of the world you were working on, forgetting to put it back in the regular raws?
Title: Re: Plant-based glazes... Why isn't this working?
Post by: Bohandas on April 11, 2011, 11:47:25 am
Quote from: NW_Kohaku on April 10, 2011, 05:55:25 pm
Quote from: Bohandas on April 10, 2011, 01:39:44 pm
Quote from: Bohandas on April 08, 2011, 12:20:40 pm
Ha ha! I've got it working!

Spoiler: Reactions (click to show/hide)

Spoiler: plants (click to show/hide)

(Technically I only currently have comfirmation that the comedy stick laughing lacquer actually works, but at least I know I've got it working)

Ok, this is weird, I put this into another world, and now its stopped working again.

Are you sure you didn't change the raws inside the save of the world you were working on, forgetting to put it back in the regular raws?

I'm not completely sure I understand what you mean. (Although that may be my fault for being ambiguous in my previous post. What I meant was that the reaction didn't work in the other world after I corrected the reaction raws in that world (the rection was already defined in the new world, but it was the old version, and I copy-and-pasted the corrected versiion into the raws from here over the definition that was there))
Title: Re: Plant-based glazes... Why isn't this working?
Post by: NW_Kohaku on April 11, 2011, 11:53:51 am
Well, if it was working in one world, and then you copy-pasted it into another world, and it didn't work, maybe you didn't remember to copy-paste everything you changed, or else you didn't overwrite everything you should have?

If it works in one world, it should work in every world, after all, unless there was some mistake in the copying.