Bay 12 Games Forum

Oh, you have GDB? Oh, wonderful! I have not been able to get it to run on my machine!

Not sure what you need to do in Macs, but in Linux all you have to do is install it using you package manager.
This is all I had to do:
sudo pacman -Syyu && sudo pacamn -S gdb

Very easy, see! 

Ok, changing phase III of the function to this fixes bug 4:
   //Phase III - who lives and who dies
   switch (alignment)
   {
      case ALIGN_ELITELIBERAL: //All good guys live, all bad guys die
         amsurvival = -abs(amsurvival);
         alsurvival = -abs(alsurvival);
         hmsurvival = -abs(hmsurvival);
         hlsurvival = -abs(hlsurvival);
         break;
      case ALIGN_LIBERAL: //One of the good guys dies, bad guys don't live
while (true)
{
randomint = LCSrandom(4);
if (randomint == 0 && pmsurvival)
{
pmsurvival = -1;
break;
}
else if (randomint == 1 && plsurvival)
{
plsurvival = -1;
break;
}
else if (randomint == 2 && smsurvival)
{
smsurvival = -1;
break;
}
else if (randomint == 3 && slsurvival)
{
slsurvival = -1;
break;
}
}
        amsurvival = -abs(amsurvival);
        alsurvival = -abs(alsurvival);
        hmsurvival = -abs(hmsurvival);
        hlsurvival = -abs(hlsurvival);
        randomint = LCSrandom(abs(amsurvival) + abs(alsurvival) + abs(hmsurvival) + abs(hlsurvival));
        break;
      case ALIGN_MODERATE: //33% of survival for everybody, but somebody on each side survives.
         if (LCSrandom(3))
            pmsurvival = -abs(pmsurvival);
         if (LCSrandom(3))
            plsurvival = -abs(plsurvival);
         if (LCSrandom(3))
            smsurvival = -abs(smsurvival);
         if (LCSrandom(3))
            slsurvival = -abs(slsurvival);
         if (LCSrandom(3))
            amsurvival = -abs(amsurvival);
         if (LCSrandom(3))
            alsurvival = -abs(alsurvival);
         if (LCSrandom(3))
            hmsurvival = -abs(hmsurvival);
         if (LCSrandom(3))
            hlsurvival = -abs(hlsurvival);

while (!(pmsurvival || plsurvival || smsurvival || slsurvival))
{
randomint = LCSrandom(4);
if (randomint == 0 && abs(pmsurvival))
{
pmsurvival = 1;
}
else if (randomint == 1 && abs(plsurvival))
{
plsurvival = 1;
}
else if (randomint == 2 && abs(smsurvival))
{
smsurvival = 1;
}
else if (randomint == 3 && abs(slsurvival))
{
slsurvival = 1;
}
}

while (!(amsurvival || alsurvival || hmsurvival || hlsurvival))
{
randomint = LCSrandom(4);
if (randomint == 0 && abs(amsurvival))
{
amsurvival = 1;
}
else if (randomint == 1 && abs(alsurvival))
{
alsurvival = 1;
}
else if (randomint == 2 && abs(hmsurvival))
{
hmsurvival = 1;
}
else if (randomint == 3 && abs(hlsurvival))
{
hlsurvival = 1;
}
}
        break;
      case ALIGN_CONSERVATIVE:  //One of the bad guys dies, one of the good guys lives
while (true)
{
randomint = LCSrandom(4);
if (randomint == 0 && pmsurvival)
{
pmsurvival = -1;
break;
}
else if (randomint == 1 && plsurvival)
{
plsurvival = -1;
break;
}
else if (randomint == 2 && smsurvival)
{
smsurvival = -1;
break;
}
else if (randomint == 3 && slsurvival)
{
slsurvival = -1;
break;
}
}

         amsurvival = -abs(amsurvival);
         alsurvival = -abs(alsurvival);
         hmsurvival = -abs(hmsurvival);
         hlsurvival = -abs(hlsurvival);

while (!(amsurvival || alsurvival || hmsurvival || hlsurvival))
{
randomint = LCSrandom(4);
if (randomint == 0 && abs(amsurvival))
{
amsurvival = 1;
}
else if (randomint == 1 && abs(alsurvival))
{
alsurvival = 1;
}
else if (randomint == 2 && abs(hmsurvival))
{
hmsurvival = 1;
}
else if (randomint == 3 && abs(hlsurvival))
{
hlsurvival = 1;
}
}
         break;
      case ALIGN_ARCHCONSERVATIVE: //good guys lose, bad guys win
         amsurvival = -abs(amsurvival);
         alsurvival = -abs(alsurvival);
         hmsurvival = -abs(hmsurvival);
         hlsurvival = -abs(hlsurvival);
         break;
      case ALIGN_STALINIST: //Only the "hero" survives - and the hero becomes evil by the end of the story
         pmsurvival = abs(pmsurvival);
         plsurvival = -abs(plsurvival);
         smsurvival = -abs(smsurvival);
         slsurvival = -abs(slsurvival);
         amsurvival = -abs(amsurvival);
         alsurvival = -abs(alsurvival);
         hmsurvival = -abs(hmsurvival);
         hlsurvival = -abs(hlsurvival);
         break;
      default: break;
   }

Now a fifth bug has revealed its left 

Movie creation sometimes gives a SIGFPE (Arithmetic exception). This is because Film->budget can equal zero.
(gdb) down
#3  0x0000000100047b13 in mode_title () at title/titlescreen.cpp:618
#2  0x00000001000761c3 in mode_base () at basemode/basemode.cpp:565
#1  0x0000000100145dd2 in passmonth (clearformess=@0x7fffffffd60b: 1 '\001', canseethings=canseethings@entry=0 '\000') at monthly/monthly.cpp:777
#0  0x000000010006fe3a in Advance_Movie (Film=0x1011bcbe0, canseethings=canseethings@entry=0 '\000') at monthly/tvrecord.cpp:982

Changing line 982 from:
advanceprob = 5000000 / Film->budget;                                                                                                                        │
to:
    if (Film->budget == 0)
{
   Film->budget = -1;
}
    advanceprob = 5000000 / Film->budget;                                                                                                                        │
fixes the problem.

And here is the solution to bug 3: the game is set to save to saveTV1.3.dat but it loads from saveTV1.4.dat
$ ag -Qi "saveTV1.3"
daily/daily.cpp
38:   //*JDS* Save the game to saveTV1.3.dat each day.
39:   if(!disbanding&&autosave) savegame("saveTV1.3.dat");

title/titlescreen.cpp
620:   savegame("saveTV1.3.dat");

title/saveload.cpp
449:/* loads the game from saveTV1.3.dat */
1022:/* deletes saveTV1.3.dat (used on endgame and for invalid save version) */

includes.h
1481:/* loads the game from saveTV1.3.dat */
1483:/* deletes saveTV1.3.dat (used on endgame and for invalid save version) */

Replace all of those with 1.4 instead.

Tada! The game is now slightly stable-er.

Hello,
I got 3 bugs to present:

A) Disbanding your squad currently gives a SEGV.

Steps to reproduce:
1- Start a game.
2- Press L then D
3- Type in the phrase.
4- Profit!

Whats happening is that when you disband the location of the squad members is set to "-1". Then: advanceday (clearformess=clearformess@entry=@0x7fffffffd78b: 1 '\001', canseethings=canseethings@entry=0 '\000') at daily/daily.cpp:1108 calls check_child_conception (Bearer=0x10116cb00) at daily/daily.cpp:2687 which then calls check_fertility (Me=0x10116cb00) at daily/daily.cpp:2782 which then checks for a negative location...

Solutions:
1) keep tracking their location after the squad is disbaned
2) guess their location
3) ignore their location

B) Game will randomly SEGV when continuing to next day.

Steps to reproduce:
A) Start a game
B) Advance the day for 1 month to forever.

This happened so few times that I couldn't debug it properly.

It happens when TVRecord_InputSleeperView calls namecreaturetype on line 201 (src/monthly/tvrecord.cpp) which then calls makecreature on line 46 (src/monthly/tvrecord.cpp). namecreaturetype passes *LocalCreature to makecreature, which sometimes is an invalid piece of memory (maybe the object got deleted by something?). makecreature than calls drop_weapon_and_clips on the creature it got passed (line 33, creaturetypes.cpp), which then tries to set LocalCreature's member variable has_thrown_weapon to false, which is an invalid piece of memory because LocalCreature doesn't exist.

And now the final bug:
The game doesn't load saves.

How to reproduce:
1) Confirm you have no ~/.lcs
2) Start crimesquad and start a game
3) Press X (Live to fight EVIL another day)
4) Notice how you know have an ~/.lcs with a save which probably is valid (I don't know how to check if is or not)
5) Start crimesquad again, notice how its asking to make a new save

Hello,
I compiled a version of the game for linux (I know that's not officially supported) and the games sometimes crashes randomly, but that's not my main issue.

My main issue is that the games ALWAYS crashes when trying to load a save. I've also tried running the windows version on wine, same issue.

Steps to Reproduce:
1- remove ~/.lcs (if you have it)
2- Start game
3- Hit enter a couples times (advanced gameplay options have no effect on the crash), followed by any series of letters (to skip past character history), then enter  to finally generate the world
4- Hit X to close the game
5- Try to restart the game and get a segmentation fault

I've gathered a lot of data to help you debug it:
https://pastebin.com/MPUbjku6 (# are comments I left, ┗❯ is the terminal)