Bay 12 Games Forum

In the Unity "Assets" menu there should be an "Open C# project" option at the bottom which will open visual studio with a connection to the Unity editor, which will allow it to read and compile the scripts properly.

Yeah currently there's no way to dismiss a Liberal other that suicide by cop - I will probably add it at some point along with manual promotion.

The recruitment option is a bit trickier because I'd probably have to set up a whole custom interface for it that's more complex than other activities (I seem to recall even the original game could get buggy when you used it). I'd originally planned to include it but it was one of those things where the amount of effort involved vs. the actual value it added to the game kind of made it into a low priority thing.

Doing multi-city actually wouldn't be a HUGE extension of the existing code - as far as the game is concerned a location is just a thing independent of any organizational structure and how they're arranged is more for the convenience of the player than a hard requirement. You'd basically just need to add another layer to the hierarchy where you have a "Country" entity that holds a list of "City" entities and then up date the UI to reflect that. The biggest change would probably just be in the logic that loads the city definition from the xml files. Some logical changes would probably be needed in a few methods like when someone gets arrested or sent to the hospital - right now those assume that only one of the relevant location exists (they would technically still work in that they would send them to a location of that type - but it might not be the local one). I'll look into adding support for this but I've been taking a bit of a break from anything too major on this so I don't want to make any promises.

For the class you've mentioned, any class that extends MonoBehaviour is a Unity object and works through the Unity editor's interface rather than the code itself. For that specific example, it's a script used on a prefab (called "LawAlignment", stored in the Assets/Prefabs/Base Screen folder). None of those variables are set in code and it isn't created through a constructor the same way you'd be used to - rather in the Unity editor all of those fields are set in the hierarchy or on the prefab definition (a prefab is basically just a specific saved copy of a hierarchy object that you can freely duplicate either in the editor or at runtime), and it gets instantiated by setting a reference to the prefab on another object (In this case, it's an object in the hierarchy itself, under Main Camera -> Canvas -> Base Screen -> Liberal Agenda, and the LiberalAgendaImpl script on that object), and then calling Instantiate in the code with that reference as input.

For this kind of stuff you're probably going to want to familiarize yourself with how Unity structures things in general, since that's where all the UI logic lives. Unity does things in a way that's slightly different than how you'd expect to handle them in code, and basically requires using the editor interface to do a lot of stuff. To give an example of how you'd do the thing you asked, what you could do is copy the Liberal Agenda object from under the Base Screen object in the hierarchy and paste it as a child of the Site Screen object. In this copy you'd want to remove any of the UI elements that you won't want accessible on the Base Screen (Like maybe the poll or map buttons), and rearrange anything that doesn't fit in nicely with the Site interface. Since this is all just layout on a copy, there's no code changes needed and nothing will be affected on the original agenda screen. Once you've got the UI arranged how you want in the hierarchy, you'd just need to modify the SiteScreenController to give it a "public LiberalAgendaImpl LiberalAgendaView;" variable to set in the editor with a reference to the screen you just added, then add a method that will call the "show()" method of that object and hide any elements you don't want displayed while it's there, and then add a button on the Site Screen UI that will call that method.

Press F1.

As someone who is just starting out learning Unity (I'm past the "Hello World" stage and into the top-down-shooter-controls-and-camera nightmare that traditionally comes next ), I am so incredibly grateful to you for sharing it as a Unity project.  Just being able to look at a feature-complete game that I'm relatively familiar with (I've played many previous iterations of the LCS codebase) is going to be hugely helpful in getting my head around some of the ways-you-can-use-Unity concepts.

So, thank you.  And that's without even having played it yet.    Downloading now!

I should probably warn you up front that this isn't a GREAT use of Unity. I ended up fighting it a lot and in retrospect I think it would have worked better had I made more use of the Unity interface rather than trying to handle everything in code. I guess it does serve as a demonstration of how you can do that (some Unity games are set up like this - as I understand it the Roguelike Caves of Qud is also designed this way), but it's not what I would recommend as an approach if you're planning to really get in to Unity.

Hmm, the save and log file for the portrait issue look fine so I can't really tell what the problem is there. It may be some Linux specific thing. I'll look into some of the details on the methods I'm using to generate portraits to see if there are any system specific aspects to them that might be cause the problem.

The save corruption looks like it's due to the CEO entity not having saved correctly - there's a hanging reference to them in the Government entity but no matching entity to be referenced. Do you remember specifically what you'd done just before you quit out that might have caused that to happen? The CEO handling is a bit hacky so it's very likely there's some edge case that I've missed.

*edit* yeah looks like there's a LOT of edge cases I've missed. I'm looking at how persistent non-liberal entities are being handled and there are a ton of holes where they could be created in-game and registered to persistent handlers, but not persisted themselves, so the save game would be left with the same kinds of references to entities that don't exist as far as the game is concerned. It looks like the CEO is especially bad about this, because it is created as soon as you activate the special tile in the CEO house, but it's not actually saved unless you recruit them.

Quote from: The Cheshire Cat on September 20, 2018, 10:46:57 pm

Well, for the most part yes, but bear in mind that I'm not really a better programmer than anyone else who worked on the original and a lot of this was learning as I went, so it's not really "well designed" even if it is more OO than the original. Like, you won't really deal with as much "spending 10 minutes to try to figure out where this variable is actually set/used" as you would in the old LCS code, but I haven't really broken up my classes as much as they could be and there's a lot of weird stuff I do that I don't think is very good C# practice.

And don't get me started on the while(true) loops, the nested for loops within switch statements, and the 2000 line method.

It's amazing you've managed to port it to Unity at all, let alone creating a new GUI.

Well bear in mind it's not a straight "port", it's a remake. I used the source code as a reference for how various mechanics were implemented so that the rolls and such being done would match up, but it's not a straight up "put everything from the original game into Unity" copy. So when it came down to something really confusing rather than just copying it over directly I tended to try to just determine the intention behind what was being done, and implemented it in a way that was simpler to me. Like the actual flow of say, a round of combat is basically the same as the original game, but the way it's being handled is different.

Quote from: The Cheshire Cat on September 19, 2018, 07:48:12 pm

Quote from: Megaman_zx on September 19, 2018, 01:04:40 pm

How easy is this to mod? Is it similar to normal LCS, easier, harder?
If it is really different, can you post a modding guide?

Depends what you're trying to mod. You can add new items, creatures, locations etc. just by editing xml files. The directions for these are inside the files themselves. Adding new functionality is a bit trickier since you need to import the project into Unity to build it, and the general design of the code is much different than the original game so you'd need to kind of re-learn how things are put together. At some point I am planning to post an explanation of how the code is structured but it'll probably take a while to write up.

One thing we can be sure is that object-oriented programming will be more proeminent than in the original code, thereby ensuring things will be more easily added or modified.

Well, for the most part yes, but bear in mind that I'm not really a better programmer than anyone else who worked on the original and a lot of this was learning as I went, so it's not really "well designed" even if it is more OO than the original. Like, you won't really deal with as much "spending 10 minutes to try to figure out where this variable is actually set/used" as you would in the old LCS code, but I haven't really broken up my classes as much as they could be and there's a lot of weird stuff I do that I don't think is very good C# practice.

I would like to do a bunch of refactoring to try to improve the usability of the code overall and to break up some of the "superclasses", but it's not as high a priority for me as just generally fixing bugs and making the player experience roughly match the original game.