Bay 12 Games Forum

Something that might be of interest to you: during my analysis of version 0.28.181.40d, I discovered that a few specific personality traits did indeed have an impact on worldgen behavior:
* High values of EXCITEMENT_SEEKING / ACHIEVEMENT_STRIVING and low values of CAUTIOUSNESS would make civ leaders more likely to declare wars in general
* High values of EXCITEMENT_SEEKING / ACHIEVEMENT_STRIVING / ANGER / SELF_EFFICACY would make civ leaders more likely to declare wars, even in the face of insurmountable odds

I managed to locate the same logic in version 0.47.05, and it's very similar:
* High values of CONFIDENCE, AMBITION, THOUGHTLESSNESS, and EXCITEMENT_SEEKING increase the chances of declaring wars in general
* High values of CONFIDENCE, AMBITION, THOUGHTLESSNESS, and ANGER_PROPENSITY increase the chances of declaring "unwinnable" wars
There's an additional check against EXCITEMENT_SEEKING and AMBITION by itself, and it seems to be in the general proximity of code for establishing alliances.

Some screenshots of your alert's Schedule might be of use in diagnosing your problem - even better would be a copy of your saved game uploaded to DFFD.

I'm trying to figure out what's going on with some crashes.  The crash frequency is currently about 1x a week.  It's too random and unpredictable currently to make a report at this point.  I've never let a fort get above 250 dwarves until this one, so I'm strongly suspecting that is a major factor.  But it was my previous understanding that the only downside to large populations was FPS loss. 

Are you using any third-party utilities such as DFHack or Dwarf Therapist? If so, it's possible your crashes are being caused by one of them, rather than by a bug in the game itself.

Other than that, I've never heard of high dwarf populations causing instability.

In another thread I suggested trying to assign the artifact to a Display Case or Pedestal and it was successful - if your thief is in a Cage, you might want to try that.

Quote from: voliol on October 28, 2021, 04:35:22 am

Quote from: Bumber on October 27, 2021, 11:59:49 pm

What is the question here, all of the post? Only the edit is marked in green.

Would like to know the proper names of the enum values, for verification. They're just integers in compiled code, so DFHack has them as best guesses based on use. Posting the correct names would be easier and more useful than answering the original (now unmarked and spoilered) question, which involves a specific segment of code.

DFHack's term "VERMIN_ESCAPED_PET" is either overly specific, DFHack's got something out of order, or Toady's code is checking the wrong one for some reason.

Edit: Just added the integer values to my post and noticed "CONTAINS_ITEM" and "VERMIN_ESCAPED_PET" share a value of 10. This might suggest it's an issue in the code, but "UNIT_HOLDER" doesn't have the same problem.

For what it's worth, all of the "general_ref" names were taken directly from the class names (which are visible in RTTI), and for the other enum there's a function that's used to load references from savegames and it logs unique error messages for each type (e.g. "Nuked Vermin Reference (Escaped Pet)") and I used those for the names.

update: a guild representative came. No elven diplomat though. I already have an agreement with them, but I guess if one starts the game like this, no way to annoy the elves by cutting trees would exist?

Good enough for me, the elves will bring me giant grizzly bears (sadly they don't seem to have any giant great cats this time) with the next caravan so I may breed them.

The stock raws should already have Diplomats, but they don't arrive at the same time as the caravan - they show up a bit earlier or later, and they also only show up once you have a Baron.

Also, if you wanted the Trader position to be named something other than "Guild Representative" (which is appropriate for Human civilizations but probably not the Elves), you could've renamed it in the script before running it.

Positions can't just be added to the raws for an existing world, because the raws are only used when dynamically creating new civilizations during worldgen - if you want to add a position to an existing civilization, you have to add it in-memory.

Fortunately, you wouldn't have to start from scratch - if you have DFHack, you can edit the "hack/scripts/fix/merchants.lua" script and modify it to apply to Elves instead of Humans (and probably also skip the "ESTABLISH_COLONY_TRADE_AGREEMENTS" responsibility, since I think that was there due to a misunderstanding when I initially wrote it).