Bay 12 Games Forum

Quote from: splinterz on August 16, 2014, 04:09:34 am

thanks, i took another look at the full view (again). seems it's also missing burial, animal care and alchemy. the last two i think can be omitted as they don't actually do anything, but burial needs to be there for sure.

One thing they do do is contribute to sorting by "Total Assigned Labors".  I noticed that as I use Total Assigned Labors to find underutilized dwarves who might be interested in joining the military, and was surprised to find that some were dodging the draft by claiming to be animal caretakers.

That's not to say that animal care and alchemy should be displayed in the "Labors Full" list, but if we can't turn them off from there then maybe they shouldn't be counted towards TAL?

yeah i'd wanted to add another grouping for total assigned skilled labors, but i'd forgotten about it. i'll add it to the tracker now.

Are you guys still looking for the cause of that duplicate preferences bug? I stumbled upon a way to reproduce it today. Assign a dwarf to a custom profession, then clear all pending changes, and the dwarf will show double preferences, skills, etc.

Windows 7, Therapist version 23.6.

great, thanks! this will be fixed in the next version, along with some other optimization for commit/clearing pending changes which were related.

I'm having trouble getting the nice_name() function in filters to work.

d.nice_name() == "" is the example in the Guide, but it matches none of my dwarves (and some have nicknames, and some don't).

d.nice_name()!="" matches everyone, even those without nicknames.

d.nice_name()=="Carpenter" matches nobody, even though I have 2 dwarves with that nickname.

Basically, I can't get nice_name() to match anything. Am I doing something wrong, or is it just not working correctly?

Grouping by nickname is working fine, though.

   Keith

the nice_name() function returns the name that you see in the first column. so doing a == comparison only matches the exact name, not a partial match. however, it looks like what you really want is the ability to check the nickname, so i've exposed that function to the scripting in the next release.

Due to an unfortunate incident with a weremoose, one of my dwarves ended up in a cage (which almost certainly saved his life). He no longer showed up in Dwarf Therapist as long as he was inside the cage. Once I released him he showed up in DT again. The population count was also down by one while he was in the cage.

   Keith

this should be fixed in the next release, but i wasn't able to test it.

Quote from: splinterz on August 16, 2014, 05:08:27 am

but anyway, progress indeed. try adding this to the df-structures script and see if the value is something other than 0x0:

Code: [Select]

emit_addr 'item_type',%all,'item::vtable','getType';

The df-structures script doesn't work on osx, because there are no .csv files to work on. The lips utils only generate them for linux and win, I tried editing them a few days ago to generate the necessary files, but gave up after a while.
Tried this with the export-dt-ini script, but doesn't work:

Code: [Select]

address('item_type',all,'item::vtable','getType')

Code: [Select]

...cnewbie/Dwarf Fortress/hack/scripts/export-dt-ini-fr.lua:40: attempt to index local 'base' (a nil value)
stack traceback:
...cnewbie/Dwarf Fortress/hack/scripts/export-dt-ini-fr.lua:40: in function 'address'
...cnewbie/Dwarf Fortress/hack/scripts/export-dt-ini-fr.lua:374: in main chunk
(...tail calls...)

oh right.. well this is where the item's type is set, but since the offsets seem to be off, then you'll have to poke around in the memory there and see if you can find where it's returning the item's type.

i'll see about updating the lua script, but i'm going to need some help since it doesn't seem capable of exporting vtable offsets.

Hey guys,

Sorry if you were already aware of this but I didn't see anyone mention it in the thread. I'm using v. 23.6 and it's missing push/haul vehicles in the All Labors view.

Thanks for all your hard work

thanks, i took another look at the full view (again). seems it's also missing burial, animal care and alchemy. the last two i think can be omitted as they don't actually do anything, but burial needs to be there for sure.

Quote from: splinterz on August 15, 2014, 06:25:33 am

Quote from: fricy on August 15, 2014, 05:58:42 am

Quote from: splinterz on August 15, 2014, 03:43:44 am

no, that means that it's not recognizing the -debug arg... ermm.. well shit. i guess you can try manually setting it to debug mode by adding

Code: [Select]

debug_logging = true; here, just before the comment

I hate to say it, but no change in the logs. Built a debug version with debug_logging = true; nothing, tried adding the -debug arg, tried compiling with 5.3 and 5.2.1 both, no change.

i don't know how that's even possible... this may be a stupid question but are you sure you're looking at the right log file? there should be entries within the first ~50 lines like:

Code: [Select]

2014-Aug-15 13:23:34.055 DEBUG core Loading language translation tables [src\languages.cpp:58] (load_data)

Are there any other log files besides DwarfTherapist.app/Contents/MacOS/log/run.log ? I already checked the ~/.config/UDP Software folder for logs, but there's none. Nothing in the system logs (Console.app) either.
I checked an old copy of 6.12 and there I can see the debug messages in the .log, for eg. there's the "Loading language..." line you quoted.

if you're building the source there should be a log file in the location where qtcreator is running it from. you should see where it's building/running it from in the project settings where you put the -debug arg as executable: path here.

I'd like to check, is QT5 absolutely necessary for building on linux? I can get QT4 on Gentoo but getting QT5 on a 64bit Gentoo is really an absolute troll.

there was actually a pull request this morning that allows DT to compile with QT4 as well as QT5. i plan to get it merged in today with the other pull for faster reads, so you can wait for that or try out that branch yourself.

Quote from: splinterz on August 14, 2014, 11:59:45 am

in qtcreator go to the projects, then choose the run settings. you'll have a bunch of options below for the environment, etc. add -debug into the arguments like this. then you should have a crapload of stuff in the log file.

derp

Code: [Select]

dwarftherapist-Desktop_Qt_5_2_1_clang_64bit-Debug/bin/debug/DwarfTherapist.app/Contents/MacOS/etc/memory_layouts/osx/v0.40.08_osx.ini" [../DwarfTherapist-git/src/dfinstance.cpp:1484] (get_memory_layout)
2014-Aug-14 21:41:18.644 INFO core Connection to DF version "v0.40.08 osx" established. [../DwarfTherapist-git/src/mainwindow.cpp:345] (connect_to_df)
2014-Aug-14 21:41:18.655 WARNING core vector at "0x00048200" has over 500000 entries! ( 462829616 ) [../DwarfTherapist-git/src/dfinstance.cpp:156] (check_vector)
2014-Aug-14 21:41:18.655 INFO core vector at "0x00048200" was not read due to an unacceptable size! ( 462829616 ) [../DwarfTherapist-git/src/dfinstance.cpp:168] (check_vector)
2014-Aug-14 21:41:18.663 WARNING core unidentified column type in set "General" ! [../DwarfTherapist-git/src/grid_view/viewcolumnset.cpp:307] (read_from_ini)
2014-Aug-14 21:41:18.667 WARNING core unidentified column type in set "General" ! [../DwarfTherapist-git/src/grid_view/viewcolumnset.cpp:307] (read_from_ini)
Line 3-4 only appeares if DT can't connect to a loaded world upon initialisation, line 5-6 is always there. Here is a full log. and the v0.40.08_osx.ini again.

still no debug info. you should see lines with DEBUG in addition to INFO or WARNING, and there should be quite a few.

Quote from: splinterz on August 14, 2014, 05:56:46 am

Quote from: fricy on August 14, 2014, 05:29:55 am

Quote from: splinterz on August 14, 2014, 04:43:48 am

hrmm, then it may one of those last few offsets in the dwarf section that are off (inventory_item_mode, inventory, inventory_item_bodypart) or it could be it's not finding bodypart names to group them by. do you see any health info/wounds?

Health screen looks to be in order - more or less: the population is healthy in my test fort, only one dwarf showing up in Therapist with Thisty, but not on the health screen. However when I sent my squad onto a drop-bridge the injuries and stunned statuses showed up correctly in DT. How do I check if the inventory address is correct?

alright then i guess it's just not finding the inventory. i don't think i'm outputting anything to the log currently that lists an inventory count or anything. are you building the source yourself? i could push a quick commit to add some debug info for the inventory counts and/or show you where to step through the code to check the inventories.

Yes, building them myself, sounds like a plan, thx.

ok i've pushed a small commit with some log messages for the inventory read. you'll have to run with the -debug argument to see them though. in the code it's this function that reads the inventory if you want to break and step through.

Edit: cleaned up the inventory logging and added a few more details on what exactly the items are