Bay 12 Games Forum

Please login or register.

Login with username, password and session length
Advanced search  
Pages: 1 ... 190 191 [192] 193 194 ... 222

Author Topic: Dwarf Therapist (Maintained Branch) v.37.0 | DF 42.06  (Read 966958 times)

TV4Fun

  • Bay Watcher
    • View Profile
Re: Dwarf Therapist (Maintained Branch) v.37.0 | DF 42.06
« Reply #2865 on: December 10, 2016, 02:38:20 pm »
Quote from: Quietust on December 10, 2016, 09:14:29 am
Quote from: TV4Fun on December 09, 2016, 07:23:07 pm
MSVC. I made a simple fix that makes it work without causing a memory leak. Will send a PR.
Saying your compiler is "MSVC" is sort of like saying your operating system is "Windows" - the version number is very important when diagnosing problems.
It's MSVC 2015. That didn't seem relevant for this particular problem, as the issue is obviously support for VLAs, which aren't supported on any version of MSVC but are supported by GCC.
Logged

anironpart

  • Escaped Lunatic
    • View Profile
Re: Dwarf Therapist (Maintained Branch) v.37.0 | DF 42.06
« Reply #2866 on: December 10, 2016, 03:15:00 pm »
I'm on the latest version of Hello71's fork and getting a crash on reading. Idk if its something wrong on my end or not.

Spoiler (click to show/hide)
Logged

Hello71

  • Bay Watcher
    • View Profile
Re: Dwarf Therapist (Maintained Branch) v.37.0 | DF 42.06
« Reply #2867 on: December 17, 2016, 08:05:00 pm »
Quote from: anironpart on December 10, 2016, 03:15:00 pm
I'm on the latest version of Hello71's fork and getting a crash on reading. Idk if its something wrong on my end or not.

Spoiler (click to show/hide)

update to new DT and layout
Logged

anironpart

  • Escaped Lunatic
    • View Profile
Re: Dwarf Therapist (Maintained Branch) v.37.0 | DF 42.06
« Reply #2868 on: December 19, 2016, 09:09:41 pm »
Thanks, the new memory layout did the trick
Logged

gasznak

  • Bay Watcher
    • View Profile
Re: Dwarf Therapist (Maintained Branch) v.37.0 | DF 42.06
« Reply #2869 on: December 20, 2016, 12:14:11 pm »
Where can I find that new version od Dwarf Therapist?
Logged

kenlon

  • Escaped Lunatic
    • View Profile
Re: Dwarf Therapist (Maintained Branch) v.37.0 | DF 42.06
« Reply #2870 on: December 21, 2016, 04:46:28 pm »
Hmm - I can't write custom profession names into DF, but I can read them just fine. Is that a known issue with the linux version? I assume it's in some way related to the 64-bit version having broken the write_raw_ptrace goop in dfinstancelinux.cpp (I found https://github.com/splintermind/Dwarf-Therapist/issues/123 from back in 2014), but I don't speak C++ and have no idea how to hunt the problem myself.
Logged

Hello71

  • Bay Watcher
    • View Profile
Re: Dwarf Therapist (Maintained Branch) v.37.0 | DF 42.06
« Reply #2871 on: December 21, 2016, 09:41:46 pm »
writing requires remote syscall in order to work reliably, and I haven't figured out how to do that yet. not a technical issue, just haven't bothered. if you can figure out how ptrace syscalls are supposed to work, fix DFInstanceLinux::remote_syscall.

edit: writing *strings*
« Last Edit: December 22, 2016, 11:32:09 am by Hello71 »
Logged

kenlon

  • Escaped Lunatic
    • View Profile
Re: Dwarf Therapist (Maintained Branch) v.37.0 | DF 42.06
« Reply #2872 on: December 21, 2016, 09:56:58 pm »
Well, like I said, I don't speak C++, but what the hell, I'll see what I can do.
Logged

thistleknot

  • Bay Watcher
  • Escaped Normalized Spreadsheet Berserker
    • View Profile
Re: Dwarf Therapist (Maintained Branch) v.37.0 | DF 42.06
« Reply #2873 on: December 24, 2016, 11:57:02 pm »
why is nurse all in red?  Its attribute only and from a glance it doesn't look right.
Spoiler (click to show/hide)
Logged

feelotraveller

  • Bay Watcher
  • (y-sqrt{|x|})^2+x^2=1
    • View Profile
Re: Dwarf Therapist (Maintained Branch) v.37.0 | DF 42.06
« Reply #2874 on: December 25, 2016, 04:58:14 am »
Hi thistleknot, been a while.   :)

Definitely doesn't look right.  Try 'custom roles/new custom role' from menu to get weightings to show (or maybe there is an easier way... I don't remember).  Is your Attribute weighting set very low/zero?  (Or skill weighting very high?)  Have a play.  Seems to affect your Lawdwarf role too... and I think they are the only -default- ones without some sort of skill associated.  For reference I definitely don't get this with the last fort I played (just loaded to check) but can't remember if I fiddled with my weightings at some point.

« Last Edit: December 25, 2016, 05:03:02 am by feelotraveller »
Logged

thistleknot

  • Bay Watcher
  • Escaped Normalized Spreadsheet Berserker
    • View Profile
Re: Dwarf Therapist (Maintained Branch) v.37.0 | DF 42.06
« Reply #2875 on: December 25, 2016, 11:50:13 am »
I do have attribute weights set low, but if I recall correctly that shouldn't be resulting in an attribute only role being low.  The only reason it should be low is if the aggregate of the role's attributes happen to be below average attribute values.

Either way, even with setting everything to weight of 1 (including potentials) nurse and lawdwarf all score below 50%.

Playing mw mod.

May have to investigate further and export raw values on a build.  I suspect that if I create an attribute only role, that the same behaviour will play out.

edit:

I think I know what's going on.  It's not counting the fact that the role doesn't have skills to calculate.  [I think] It's passing in a 0 value for the missing skills aggregate vs excluding them [and possibly for other aspects such as traits and preferences, but unconfirmed] thereby dragging down the score.  I tried another attribute only role that counted strength only and I got all low %'s.  Then I reduced my skill weight to 0 and voila, no more red's on an attribute only role.  If I'm correct, it's an easy fix.  I think there's a logic split in the code to handle skills a bit differently and maybe it doesn't have the "if no skills, then drop skills".

I might be able to get around it but just manually setting the role's other weights to 0
« Last Edit: December 25, 2016, 11:25:45 pm by thistleknot »
Logged

feelotraveller

  • Bay Watcher
  • (y-sqrt{|x|})^2+x^2=1
    • View Profile
Re: Dwarf Therapist (Maintained Branch) v.37.0 | DF 42.06
« Reply #2876 on: December 25, 2016, 05:48:17 pm »
While your explanation is probably correct, I don't get that behaviour with the version I am running (37 with 43.03 layount, on a linux machine).  So there must be something more to it.  No idea what.  For me they just show as blank (no geometric when I change to that view) being very close to 50(text).

There was definitely a fix put in for non-match to preferences causing a lowering of the roles so perhaps look at that code?  (My understanding of that logic is if match plus vs. no change if not match, with multiple matches giving higher weights.)  It is likely that other categories of weightings (those not currently/commonly used) have not had this variance added.

If you are combing through the code one bug which occurs sporadically but is quite annoying (to me) is that sometimes when the top role match (ie the one that is 100) changes to another dwarf/role the entire weightings get thrown into a strange state where just about everything is positive (so 95%+ of the roles are 50-100 range).  Making a change to a related (to top role/dwarf) custom role (e.g. one that uses the same skill) resets the distribution to calculate normally.  So need a check for which is top rank is before the distribution calculation?
Logged

k33n

  • Bay Watcher
  • So it goes.
    • View Profile
Re: Dwarf Therapist (Maintained Branch) v.37.0 | DF 42.06
« Reply #2877 on: December 26, 2016, 06:52:57 pm »
Therapist crashes on connect, newest version of both therapist and df
Logged

lethosor

  • Bay Watcher
    • View Profile
Re: Dwarf Therapist (Maintained Branch) v.37.0 | DF 42.06
« Reply #2878 on: December 26, 2016, 07:09:24 pm »
Quote from: k33n on December 26, 2016, 06:52:57 pm
Therapist crashes on connect, newest version of both therapist and df
Are you using 32-bit or 64-bit DF 0.43.05? What platform are you using? Are you referring to the newest released version of DT (37.0) or one you compiled yourself from source? v37.0 has no support for DF 0.43.05 at all, but it shouldn't crash. Hello71's fork has some 64-bit support, but I'm unsure if it works on Windows.
Logged
DFHack - Dwarf Manipulator (Lua) - DF Wiki talk

Quote from: Toady One on September 02, 2008, 06:12:34 pm
There was a typo in the siegers' campfire code. When the fires went out, so did the game.

k33n

  • Bay Watcher
  • So it goes.
    • View Profile
Re: Dwarf Therapist (Maintained Branch) v.37.0 | DF 42.06
« Reply #2879 on: December 27, 2016, 01:45:59 pm »
I'm using the 64 bit Dwarf fortress with the 'recent version' link of therapist on Windows 10.
Logged
Pages: 1 ... 190 191 [192] 193 194 ... 222
« previous next »