Bay 12 Games Forum

Please login or register.

Login with username, password and session length
Advanced search  

Author Topic: LCS 4.12.1 Bug Report- Founder Creation Problem  (Read 543 times)

ThunderGraham

  • Escaped Lunatic
    • View Profile
LCS 4.12.1 Bug Report- Founder Creation Problem
« on: August 11, 2017, 06:46:25 pm »

Hello there,
I just started using the 4.12.1 version of LCS posted the other day, and I'm running into an issue with founder creation and stats.
When creating my founder, I chose options B, B, B, A, E, A, B, A, C, D.
In theory this should give my founder 8 HRT, 5 INT, 1 WIS, 10 HTH, 10 AGI, 10 STR, 5 CHA
However, in practice my founder's stats are 1 HRT, 2 INT, 1 WIS, 4 HTH, 5 AGI, 6 STR, 1 CHA
This only appears to happen for the specific answer sequence given above; when I answered A at question 1 as an experiment my founder's stats were calculated correctly.
Any ideas as to why this is happening, and how to fix it?
Logged

IsaacG

  • Bay Watcher
  • Mad Engineer
    • View Profile
    • JJoseph on Deviantart
Re: LCS 4.12.1 Bug Report- Founder Creation Problem
« Reply #1 on: August 11, 2017, 09:02:00 pm »

Hello there,
I just started using the 4.12.1 version of LCS posted the other day, and I'm running into an issue with founder creation and stats.
When creating my founder, I chose options B, B, B, A, E, A, B, A, C, D.
In theory this should give my founder 8 HRT, 5 INT, 1 WIS, 10 HTH, 10 AGI, 10 STR, 5 CHA
However, in practice my founder's stats are 1 HRT, 2 INT, 1 WIS, 4 HTH, 5 AGI, 6 STR, 1 CHA
This only appears to happen for the specific answer sequence given above; when I answered A at question 1 as an experiment my founder's stats were calculated correctly.
Any ideas as to why this is happening, and how to fix it?

This would be my fault.  I'm going to fix it immediately.
Logged
LCS 4.12.1 Custom NewGame and PickupLines!)
Quote
Many people, meeting Aziraphale for the first time, formed three impressions: that he was English, that he was intelligent, and that he was gayer than a tree full of monkeys on nitrous oxide.
Constitution of the Confederate States
Article I Sec. 9 4
No bill of attainder, ex post facto law, or law denying or impairing the right of property in negro slaves shall be passed.

IsaacG

  • Bay Watcher
  • Mad Engineer
    • View Profile
    • JJoseph on Deviantart
Re: LCS 4.12.1 Bug Report- Founder Creation Problem
« Reply #2 on: August 12, 2017, 05:12:15 pm »

Hello there,
I just started using the 4.12.1 version of LCS posted the other day, and I'm running into an issue with founder creation and stats.
When creating my founder, I chose options B, B, B, A, E, A, B, A, C, D.
In theory this should give my founder 8 HRT, 5 INT, 1 WIS, 10 HTH, 10 AGI, 10 STR, 5 CHA
However, in practice my founder's stats are 1 HRT, 2 INT, 1 WIS, 4 HTH, 5 AGI, 6 STR, 1 CHA
This only appears to happen for the specific answer sequence given above; when I answered A at question 1 as an experiment my founder's stats were calculated correctly.
Any ideas as to why this is happening, and how to fix it?

I have repaired the file in the download link.

There is an error in the file
v4.12.1 STABLE\art\newgame\founderQuestions.txt
The default attribute values only apply when the first question is answered "a".
A simple fix is to add another question before the first question.
A simpler fix is to add the default attribute values to each of the answers to question 1.

Or just download the fixed founderQuestions.txt and place it in art\newgame\

https://www.mediafire.com/file/azgnh37sfqngx29/founderQuestions.txt

Took longer to find than expected, because I thought it was a coding problem.  Fortunately, this can be fixed without downloading anything.

replace this
Code: [Select]
# Optional defining the starting day, month, and year
#
STARTING_DAY 1
STARTING_MONTH 1
STARTING_YEAR 2009
#
# Optional defining the founder's base stats
# If not defined, or ultimately negative, stats default to 1
# Using + or - will instead adjust the stat
#
ATTRIBUTE_HEART 8
ATTRIBUTE_WISDOM 1
ATTRIBUTE_INTELLIGENCE 3
ATTRIBUTE_AGILITY 5
ATTRIBUTE_STRENGTH 4
ATTRIBUTE_HEALTH 6
ATTRIBUTE_CHARISMA 4
#
# Optional, Next we define the Header.
# This will appear in bold at the top of the screen
# It can be redefined before each question, or kept the same throughout
#
# The order is "Header, Question, Answer, Impact"
# Redefining one causes the latter ones to end
# Impacts placed under Headers and Questions will activate
# regardless of answers, like the earlier "starting_day" variable
#
HEADER Insight into a Revolution:  My Traumatic Childhood
#
# Optional, HEADER_2 for two-line headers
#
# Next we define a question.  Implicitly the questions are chronological
# beginning with the founder's birth, but technically the founder's birth
# can be defined and redefined as many times as the modder want.
#
QUESTION The day I was born in 1984...
# Optional, QUESTION_2 for two-line questions
# and ANSWER_2 for two-line answers
# Next we define the answers to the question
# which will include the influence the answer has
# on the founder's stats and attributes
#
ANSWER the Polish priest Popieluszko was kidnapped by government agents.
# Oct. 19, 1984
ATTRIBUTE_AGILITY +2
BIRTHDAY_MONTH 10
BIRTHDAY_DAY 19
BIRTHDAY_YEAR 1984
#
ANSWER was the 3rd anniversary of the assassination attempt on Ronald Reagan.
# Mar. 3, 1984
ATTRIBUTE_STRENGTH +2
BIRTHDAY_MONTH 3
BIRTHDAY_DAY 3
BIRTHDAY_YEAR 1984
#
ANSWER the Macintosh was introduced.
# Jan. 24, 1984
ATTRIBUTE_INTELLIGENCE +2
BIRTHDAY_MONTH 1
BIRTHDAY_DAY 24
BIRTHDAY_YEAR 1984
#
ANSWER the Nobel Peace Prize went to Desmond Tutu for opposition to apartheid.
# Oct. 16, 1984
ATTRIBUTE_HEART +2
BIRTHDAY_MONTH 10
BIRTHDAY_DAY 16
BIRTHDAY_YEAR 1984
#
ANSWER the Sandanista Front won the elections in Nicaragua.
# Sept. 4, 1984
ATTRIBUTE_CHARISMA +2
BIRTHDAY_MONTH 9
BIRTHDAY_DAY 4
BIRTHDAY_YEAR 1984
#
#
with this
Code: [Select]

#
# Optional, Next we define the Header.
# This will appear in bold at the top of the screen
# It can be redefined before each question, or kept the same throughout
#
# The order is "Header, Question, Answer, Impact"
# Redefining one causes the latter ones to end
# Impacts placed under Headers and Questions will activate
# regardless of answers, like the earlier "starting_day" variable
#
HEADER Insight into a Revolution:  My Traumatic Childhood
#
# Optional, HEADER_2 for two-line headers
#
# Next we define a question.  Implicitly the questions are chronological
# beginning with the founder's birth, but technically the founder's birth
# can be defined and redefined as many times as the modder want.
#
QUESTION The day I was born in 1984...
# Optional, QUESTION_2 for two-line questions
# and ANSWER_2 for two-line answers
# Next we define the answers to the question
# which will include the influence the answer has
# on the founder's stats and attributes
#
ANSWER the Polish priest Popieluszko was kidnapped by government agents.
# Oct. 19, 1984
# Optional defining the starting day, month, and year
#
STARTING_DAY 1
STARTING_MONTH 1
STARTING_YEAR 2009
#
# Optional defining the founder's base stats
# If not defined, or ultimately negative, stats default to 1
# Using + or - will instead adjust the stat
#
ATTRIBUTE_HEART 8
ATTRIBUTE_WISDOM 1
ATTRIBUTE_INTELLIGENCE 3
ATTRIBUTE_AGILITY 5
ATTRIBUTE_STRENGTH 4
ATTRIBUTE_HEALTH 6
ATTRIBUTE_CHARISMA 4
ATTRIBUTE_AGILITY +2
BIRTHDAY_MONTH 10
BIRTHDAY_DAY 19
BIRTHDAY_YEAR 1984
#
ANSWER was the 3rd anniversary of the assassination attempt on Ronald Reagan.
# Mar. 3, 1984
# Optional defining the starting day, month, and year
#
STARTING_DAY 1
STARTING_MONTH 1
STARTING_YEAR 2009
#
# Optional defining the founder's base stats
# If not defined, or ultimately negative, stats default to 1
# Using + or - will instead adjust the stat
#
ATTRIBUTE_HEART 8
ATTRIBUTE_WISDOM 1
ATTRIBUTE_INTELLIGENCE 3
ATTRIBUTE_AGILITY 5
ATTRIBUTE_STRENGTH 4
ATTRIBUTE_HEALTH 6
ATTRIBUTE_CHARISMA 4
ATTRIBUTE_STRENGTH +2
BIRTHDAY_MONTH 3
BIRTHDAY_DAY 3
BIRTHDAY_YEAR 1984
#
ANSWER the Macintosh was introduced.
# Jan. 24, 1984
# Optional defining the starting day, month, and year
#
STARTING_DAY 1
STARTING_MONTH 1
STARTING_YEAR 2009
#
# Optional defining the founder's base stats
# If not defined, or ultimately negative, stats default to 1
# Using + or - will instead adjust the stat
#
ATTRIBUTE_HEART 8
ATTRIBUTE_WISDOM 1
ATTRIBUTE_INTELLIGENCE 3
ATTRIBUTE_AGILITY 5
ATTRIBUTE_STRENGTH 4
ATTRIBUTE_HEALTH 6
ATTRIBUTE_CHARISMA 4
ATTRIBUTE_INTELLIGENCE +2
BIRTHDAY_MONTH 1
BIRTHDAY_DAY 24
BIRTHDAY_YEAR 1984
#
ANSWER the Nobel Peace Prize went to Desmond Tutu for opposition to apartheid.
# Oct. 16, 1984
# Optional defining the starting day, month, and year
#
STARTING_DAY 1
STARTING_MONTH 1
STARTING_YEAR 2009
#
# Optional defining the founder's base stats
# If not defined, or ultimately negative, stats default to 1
# Using + or - will instead adjust the stat
#
ATTRIBUTE_HEART 8
ATTRIBUTE_WISDOM 1
ATTRIBUTE_INTELLIGENCE 3
ATTRIBUTE_AGILITY 5
ATTRIBUTE_STRENGTH 4
ATTRIBUTE_HEALTH 6
ATTRIBUTE_CHARISMA 4
ATTRIBUTE_HEART +2
BIRTHDAY_MONTH 10
BIRTHDAY_DAY 16
BIRTHDAY_YEAR 1984
#
ANSWER the Sandanista Front won the elections in Nicaragua.
# Sept. 4, 1984
# Optional defining the starting day, month, and year
#
STARTING_DAY 1
STARTING_MONTH 1
STARTING_YEAR 2009
#
# Optional defining the founder's base stats
# If not defined, or ultimately negative, stats default to 1
# Using + or - will instead adjust the stat
#
ATTRIBUTE_HEART 8
ATTRIBUTE_WISDOM 1
ATTRIBUTE_INTELLIGENCE 3
ATTRIBUTE_AGILITY 5
ATTRIBUTE_STRENGTH 4
ATTRIBUTE_HEALTH 6
ATTRIBUTE_CHARISMA 4
ATTRIBUTE_CHARISMA +2
BIRTHDAY_MONTH 9
BIRTHDAY_DAY 4
BIRTHDAY_YEAR 1984
#
#

The way 4.12.1 reads founderQuestions.txt the founder's stats are determined by the information stored in the answers, and I guess I forgot to give it access to any sort of default values.  Thus the default stats (including starting month, day, and year) are assigned as part of answer 'a' to question 1.
That means this bug has been around since I introduced custom newgames  :o
But it's feeling much better now.
Logged
LCS 4.12.1 Custom NewGame and PickupLines!)
Quote
Many people, meeting Aziraphale for the first time, formed three impressions: that he was English, that he was intelligent, and that he was gayer than a tree full of monkeys on nitrous oxide.
Constitution of the Confederate States
Article I Sec. 9 4
No bill of attainder, ex post facto law, or law denying or impairing the right of property in negro slaves shall be passed.

ThunderGraham

  • Escaped Lunatic
    • View Profile
Re: LCS 4.12.1 Bug Report- Founder Creation Problem
« Reply #3 on: August 12, 2017, 05:25:18 pm »

Excellent! That was just the ticket. Thanks a lot!
Logged

IsaacG

  • Bay Watcher
  • Mad Engineer
    • View Profile
    • JJoseph on Deviantart
Re: LCS 4.12.1 Bug Report- Founder Creation Problem
« Reply #4 on: August 12, 2017, 06:03:21 pm »

Excellent! That was just the ticket. Thanks a lot!

Glad to help.
Logged
LCS 4.12.1 Custom NewGame and PickupLines!)
Quote
Many people, meeting Aziraphale for the first time, formed three impressions: that he was English, that he was intelligent, and that he was gayer than a tree full of monkeys on nitrous oxide.
Constitution of the Confederate States
Article I Sec. 9 4
No bill of attainder, ex post facto law, or law denying or impairing the right of property in negro slaves shall be passed.