Bay 12 Games Forum

Please login or register.

Login with username, password and session length
Advanced search  

Author Topic: [CREATURE:HONEY BADGER] has no underscore between the words  (Read 819 times)

Bob69Joe

  • Bay Watcher
    • View Profile
[CREATURE:HONEY BADGER] has no underscore between the words
« on: September 19, 2018, 02:54:09 pm »

Does the honey badger show up alright in your games? Like, crocodile has CROCODILE_SALTWATER for its tag but the honey badger doesn't have that underscore. I don't know if things might screw up if I add it in, or if it's even necessary.

This is in the large_tropical creatures file, raw/objects folder. There are more right after the badger, GIGANTIC TOTRTOISE, and even stranger, the giant armadillo has a comma seperating it, "ARMADILLO, GIANT."
« Last Edit: September 19, 2018, 03:00:56 pm by Bob69Joe »
Logged

thefriendlyhacker

  • Bay Watcher
    • View Profile
Re: [CREATURE:HONEY BADGER] has no underscore between the words
« Reply #1 on: September 19, 2018, 03:02:56 pm »

As far as I know, the CAMEL_CASE style names are just a convention.  I have seen modded plants written in "camel case" that only had problems when some other raw tokens referenced the names of those plants incorrectly (they referenced them using camel_case IIRC).  HONEY BADGER should work just fine on it's own.  It is still a breach of DF's normal coding style and should be fixed, but it isn't actually a bug as far as the player is concerned.

I don't think anything else would refer to the honey badger, so you could change it's name with no problems (at least so long as you don't change it's name in an already genned world).  If it was something like breastplate armor you were changing the name of, you would also need to go into the entity file and change the ARMOR token that refers to it.
Logged
Fallout Equestria Redux - that's right, it's back

Taffer

  • Bay Watcher
    • View Profile
Re: [CREATURE:HONEY BADGER] has no underscore between the words
« Reply #2 on: September 20, 2018, 12:59:52 pm »

I don't think anything else would refer to the honey badger, so you could change it's name with no problems

Code: [Select]
[CREATURE:HONEY BADGER MAN]
[COPY_TAGS_FROM:HONEY BADGER]

Code: [Select]
[CREATURE:HONEY BADGER, GIANT]
[COPY_TAGS_FROM:HONEY BADGER]

A bigger problem are the missing left brackets in various places, which affect the game.

In creature_temperate_new.txt:
Code: [Select]
GENERAL_CHILD_NAME:giant koala joey:giant koala joeys]
In creature_standard.txt, dwarves:
Code: [Select]
Here we handle nail length.

*** need a new style to keep these short and need to make the entity def say to keep them short
SET_TL_GROUP:BY_CATEGORY:FINGER:NAIL]
PLUS_TL_GROUP:BY_CATEGORY:TOE:NAIL]
TISSUE_LAYER_APPEARANCE_MODIFIER:LENGTH:100:100:100:100:100:100:100]
APP_MOD_RATE:1:DAILY:0:1000:0:0:NO_END]
APP_MOD_NOUN:nails:PLURAL]

And again in creature_large_mountain.txt, gnomes. Probably copied from the dwarf raws.
Code: [Select]
SET_TL_GROUP:BY_CATEGORY:FINGER:NAIL]
PLUS_TL_GROUP:BY_CATEGORY:TOE:NAIL]
TISSUE_LAYER_APPEARANCE_MODIFIER:LENGTH:100:100:100:100:100:100:100]
APP_MOD_RATE:1:DAILY:0:1000:0:0:NO_END]
And the same again in creature_large_mountain.txt, dark gnomes:
Code: [Select]
SET_TL_GROUP:BY_CATEGORY:FINGER:NAIL]
PLUS_TL_GROUP:BY_CATEGORY:TOE:NAIL]
TISSUE_LAYER_APPEARANCE_MODIFIER:LENGTH:100:100:100:100:100:100:100]
APP_MOD_RATE:1:DAILY:0:1000:0:0:NO_END]

The missing brackets on the nails might be intentional of course.
« Last Edit: September 20, 2018, 01:13:34 pm by Taffer »
Logged

KittyTac

  • Bay Watcher
  • Impending Catsplosion. [PREFSTRING:aloofness]
    • View Profile
Re: [CREATURE:HONEY BADGER] has no underscore between the words
« Reply #3 on: September 20, 2018, 09:27:54 pm »

Missing brackets are also a way to comment things out.
Logged
Don't trust this toaster that much, it could be a villain in disguise.
Mostly phone-posting, sorry for any typos or autocorrect hijinks.

Taffer

  • Bay Watcher
    • View Profile
Re: [CREATURE:HONEY BADGER] has no underscore between the words
« Reply #4 on: September 20, 2018, 11:14:57 pm »

Missing brackets are also a way to comment things out.

That's what I meant by
The missing brackets on the nails might be intentional of course.

I don't see why the giant koala tag would be commented out, it seems to me to be a bug.

Logged

Bob69Joe

  • Bay Watcher
    • View Profile
Re: [CREATURE:HONEY BADGER] has no underscore between the words
« Reply #5 on: September 21, 2018, 01:07:04 pm »

The missing brackets on the nails might be intentional of course.

I don't see why the giant koala tag would be commented out, it seems to me to be a bug.

Maybe DF needs GIANT EUCALYPTUS before we get GIANT KOALA?
Logged

KittyTac

  • Bay Watcher
  • Impending Catsplosion. [PREFSTRING:aloofness]
    • View Profile
Re: [CREATURE:HONEY BADGER] has no underscore between the words
« Reply #6 on: September 21, 2018, 08:36:50 pm »

The missing brackets on the nails might be intentional of course.

I don't see why the giant koala tag would be commented out, it seems to me to be a bug.

Maybe DF needs GIANT EUCALYPTUS before we get GIANT KOALA?
They do not have special diets... why do people overestimate DF?
Logged
Don't trust this toaster that much, it could be a villain in disguise.
Mostly phone-posting, sorry for any typos or autocorrect hijinks.

Senator Jim Death

  • Bay Watcher
    • View Profile
Re: [CREATURE:HONEY BADGER] has no underscore between the words
« Reply #7 on: September 22, 2018, 04:01:23 pm »


They do not have special diets... why do people overestimate DF?

Blame pandas.
Logged
If it's not trying to be fun, it's not trying to be a video game.