I'm not aware of any bugs for plants that can be brewed (bilberry: I generally don't collect things that can't be made into booze, so I don't know much about those). However, berries and fruit are ripe only at certain times of the year, and if they contain any part that can be picked outside of that time, those plants will be picked (like strawberries, where the plant itself will be picked regardless of whether there is any berries on it or not), which means they're removed from the map and thus can't be picked when the berries ought to be ripe.
As far as I know getplant does the same thing as your area designations for picking does, except that it doesn't include the unwanted kinds of plants. It's also the same as the one applied when you designate them individually.
I would expect harvesting zones to have dorfs pick plants as soon as there is something to pick (like the area designation), without regard for your possible wishes to actually target berries/fruit.
I use this script to collect plants with the primary purpose of getting seeds for farm plots. Note that the parameter section (in the beginning) defaults to collect one of everything (to allow for growing not only for booze, thread, and paper, but for preferred foods as well). I use the script a number of times over the year, in particular the summer, to get berries. Since the script checks your existing designations as well as your current stocks, it should designate less and less over time.
-- This script designates surface plants for collection, with the primary aim to get seeds for
-- farm production. Plants already designated are taken into account.
-- The script tries to select the plants closest to the center of the embark, but does not try
-- to replace ones already designated with closer ones.
--
local get_all = true -- If true, every shrub is collected and the flags below are ignored
local get_paper = true -- If true, include paper makeing plants (only papyrus in vanilla)
local get_drink = true -- If true, include booze producing plants
local get_thread = true -- If true, include thread producing plants
local get_mill = true -- If true, include millable plants
local get_seedless = false-- Get plants that can't be grown as they produce no seeds. The vanilla
-- plants of this type are Valley Herb and Kobold Bulb. Note that get_all
-- does NOT override this setting.
local number_to_get = 1 -- Change this number if you want more of each. Note that the number of plants
-- actually collected is reduced by the number of seeds already at hand.
local verbose = false -- If true, prints a line for every designated plant and plants for which
-- we already have sufficient seeds. If false, those messages are suppressed.
--====================================
local max_x, max_y, max_z = dfhack.maps.getTileSize ()
local center_x = max_x / 2
local center_y = max_y / 2
--====================================
function distance_2 (x, y)
local dx = center_x - x
local dy = center_y - y
return dx * dx + dy * dy
end
--====================================
function closer (x1, y1, x2, y2)
-- The relation of the square of the distances is the same as that of the distances, so it's
-- redundant to take the square root to compare the actual distances.
--
return distance_2 (x1, y1) < distance_2 (x2, y2)
end
--====================================
function getone ()
for i, v in ipairs (df.global.world.raws.plants.bushes) do
local paper_plant = false
for k, material in ipairs (v.material) do
for l, reaction in ipairs (material.reaction_class) do
if reaction.value == "PAPER_PLANT" then
paper_plant = true
break
end
end
end
if (((get_all or
(get_drink and v.flags.DRINK) or
(get_thread and v.flags.THREAD) or
(get_mill and v.flags.MILL) or
(get_paper and paper_plant)) and
v.flags.SEED) or
not v.flags.SEED and
get_seedless) and
not v.flags.SAPLING and -- Should be redundant as we iterate over bushes only
not v.flags.TREE and -- -"-
not v.flags.GRASS and -- -"-
not v.flags.BIOME_SUBTERRANEAN_WATER and
not v.flags.BIOME_SUBTERRANEAN_CHASM and
not v.flags.BIOME_SUBTERRANEAN_LAVA then
local seeds = 0
local found = 0
local designated = 0
local skip = false
for k, seed in ipairs (df.global.world.items.other.SEEDS) do
if seed.mat_index == v.index then
seeds = seeds + 1
if seeds >= number_to_get then
skip = true
if verbose then
dfhack.color (COLOR_LIGHTGREEN)
dfhack.println ("Skipping " .. v.id .. " as sufficient seeds are already available")
dfhack.color (COLOR_RESET)
end
break
end
end
end
found = seeds
local candidates = {}
if not skip then
for k, plant in ipairs (df.global.world.plants.all) do
if plant.material == v.index then
local cur = dfhack.maps.getTileBlock (plant.pos)
local x = plant.pos.x % 16
local y = plant.pos.y % 16
local skip_inner
if cur.tiletype [x] [y] == df.tiletype.Shrub then
if cur.designation [x] [y].dig == df.tile_dig_designation.No then
current = df.global.world.jobs.list
skip_inner = false
while current ~= nil do
if current.item ~= nil and
current.item.job_type == df.job_type.GatherPlants and
current.item.pos.x == plant.pos.x and
current.item.pos.y == plant.pos.y and
current.item.pos.z == plant.pos.z then
table.insert (candidates, {plant, true})
skip_inner = true
break
end
current = current.next
end
if not skip_inner then
for l, u in ipairs (df.global.world.jobs.postings) do
if u.job ~= nil and
u.job.job_type == df.job_type.GatherPlants and
u.job.pos.x == plant.pos.x and
u.job.pos.y == plant.pos.y and
u.job.pos.z == plant.pos.z then
table.insert (candidates, {plant, true})
skip_inner = true
break
end
end
end
if not skip_inner then
table.insert (candidates, {plant, false})
end
elseif cur.designation [x] [y].dig == df.tile_dig_designation.Default then
table.insert (candidates, {plant, true})
end
end
end
end
if #candidates + seeds >= number_to_get then -- Need to sort the list
local temp
for l = 1, #candidates - 1 do
if not candidates [l] [2] then -- Already designated ones are kept. Don't know with certainty how to replace those.
for m = l + 1, #candidates do
if candidates [m] [2] then
temp = candidates [l]
candidates [l] = candidates [m]
candidates [m] = temp
break
end
if distance_2 (candidates [l] [1].pos.x, candidates [l] [1].pos.y) > distance_2 (candidates [m] [1].pos.x, candidates [m] [1].pos.y) then
temp = candidates [l]
candidates [l] = candidates [m]
candidates [m] = temp
end
end
end
end
end
for l, growth in ipairs (v.growths) do
if growth.id == "FRUIT" and
(df.global.cur_year_tick < growth.timing_1 or
df.global.cur_year_tick > growth.timing_2) then
dfhack.color (COLOR_YELLOW)
dfhack.println ("Found " .. v.id .. " but it's not ripe (" .. tostring (#candidates) .. ")")
dfhack.color (COLOR_RESET)
designated = false
break
end
end
if designated then
local last = #candidates
if #candidates > number_to_get - seeds then
last = number_to_get - seeds
end
for l = 1, last do
if candidates [l] [2] then
if verbose then
dfhack.println ("Already designated " .. v.id, candidates [l] [1].pos.x, candidates [l] [1].pos.y, candidates [l] [1].pos.z)
end
else
local cur = dfhack.maps.getTileBlock (candidates [l] [1].pos)
local x = candidates [l] [1].pos.x % 16
local y = candidates [l] [1].pos.y % 16
cur.designation [x] [y].dig = df.tile_dig_designation.Default
cur.flags.designated = true
if verbose then
dfhack.println ("Designated " .. v.id, candidates [l] [1].pos.x, candidates [l] [1].pos.y, candidates [l] [1].pos.z)
end
end
end
end
end
if not skip then
if #candidates == 0 then
dfhack.color (COLOR_LIGHTRED)
dfhack.println ("Failed to find any " .. v.id)
dfhack.color (COLOR_RESET)
elseif not designated then
-- Not ripe
elseif #candidates < number_to_get - seeds then
dfhack.color (COLOR_LIGHTCYAN)
dfhack.println ("Failed to find sufficient " .. v.id .. " (" .. tostring (#candidates) .. ")")
dfhack.color (COLOR_RESET)
end
end
end
end
end
getone ()
Author
Topic: Plant-Gathering shrubs with growths yields nothing? (Read 1162 times)