Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[Think0028]

I'm looking under the combat file, as I've had some bad luck with being horribly damaged lately and I was getting curious as to how it's all calculated. I noticed this bit right here:

Code: [Select]

      //SKILL BONUS FOR GOOD ROLL
      mod+=aroll-droll-5;

      if(mod>0)
      {
         //DO THE HEALTH MOD ON THE WOUND
         mod-=t.attval(ATTRIBUTE_HEALTH)-5;
         //If commented out, health works like body armor
         //if(mod<0)mod=0;
      }Later on in the code, mod is used to modify damage in a multiplicative way, and fairly significantly reduces it if it's negative.

This strikes me as really weird. Consider the following:
Say I have a liberal with 15 health. If a conservative attacks him and beats his roll by, say, 5, then he'll have a mod of 0. If the conservative beats his roll by 6, on the other hand, then he has a mod of -4, because the health reduction kicks in.

So shouldn't the if mod>0 be removed now that health can reduce the mod below zero?

[Jonathan S. Fox]

I see what you're saying, and you're right, that should be removed.