Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[Dotto]

I'm trying to use isoworld, but it keeps crashing when loading an exported map.

[Timeless Bob]

Hi!
Few days ago I started working on a simple commandline app written in C to stitch IsoWorld tiles into one big image. There were some problems like crashes on really big pngs (LodePNG) so I'm switching to libpng. The plan is to release it as open source - need to finish libpng migration, cleanup the code, add some options (everything is harcoded right now) and other stuff.

The results so far:
Here is resized 6x6 area of a pocket world (17x17), text added in GIMP:

Spoiler (click to show/hide)

Fullsize PNG (9215x4768): http://www.mediafire.com/download/39kts4xn8uad9z4/Osmlo_Olzul.png

You need to rename them to the old naming sceme for it to work, though it's not supposed to crash.

I really need to update this to use the new names, but I'm really busy with a lot of other things.

It crashed on my end (64bit Gentoo linux) I think gdb was pointing to al_path_cstr in allegro lib - can provide backtrace if needed - but that clearly leads to new naming scheme, also there was a small error while compiling (tested with gcc 4.8.3 and 4.9.1):

Spoiler (click to show/hide)

In file included from /home/majiin/repos/dfhack/plugins/isoworld/UserInterface.cpp:3:0:
/home/majiin/repos/dfhack/plugins/isoworld/MapSection.h:35:7: error: extra qualification ‘MapSection::’ on member ‘load_colors’ [-fpermissive]
  void MapSection::load_colors(s_maplist * map_list);

fixed by adding c/cxx flag -fpermissive

Thank you guys for your hard work!

For really big image files ('Small' world sizes or larger), it might be good to take a cue from other atlas programs and create a "zoomed out" overview map with a grid overlay.  Each grid square could represent one of the stitched-together maps, and clicking on it would run the stitching program for that portion of the world - if each map had overlapping edges, this redundancy would allow portions of the two large maps to be joined together to show the area between the two maps as a cohesive whole as well, allowing a map-maker to center the map precisely.

[majiin]

Old naming scheme:

world_graphic-<kind of map>-region<#>-<world age>-<numbers, fuck if I know what they mean>.bmp

New naming scheme:

region<#>-<fucking numbers again>-<kind of map>.bmp

The important thing is the region, and the kind of map (elevation, structures, biome, etc).
Don't know about the numbers, maybe world size, age, etc
For details, just generate worlds in 34.11 and 40.11, export the maps and compare for yourselves.

Edit: If someone has the time, the relevant code appears to be in main.cpp starting at line 226

Might give it a try after I finish my IsoWorld map stitcher (probably next week unless I encounter some major problems)

[Nopenope]

Trying to build IsoWorld on Linux (along with dfhack) gives the following error:

Spoiler (click to show/hide)

~/Games/DF/dfhack/plugins/isoworld/UserInterface.h:5:25: fatal error: Agui/Agui.hpp: No such file or directory
 #include <Agui/Agui.hpp>

Which is weird since there is such a file, maybe a PATH problem or something?

[Rose]

You need a Linux version of agui

[Nopenope]

After adding the header files, the error seems to have evolved:

Spoiler (click to show/hide)

~/Games/DF/dfhack/plugins/isoworld/MapSection.h:35:7: error: extra qualification ‘MapSection::’ on member ‘load_colors’ [-fpermissive]
  void MapSection::load_colors(s_maplist * map_list);

[majiin]

After adding the header files, the error seems to have evolved:

Spoiler (click to show/hide)

~/Games/DF/dfhack/plugins/isoworld/MapSection.h:35:7: error: extra qualification ‘MapSection::’ on member ‘load_colors’ [-fpermissive]
  void MapSection::load_colors(s_maplist * map_list);

You can do one of the following:
add -fpermissive to your c/cxx flags, or apply this patch

Code: [Select]

--- plugins/isoworld/MapSection.h 2014-09-11 17:47:18.331186059 +0200
+++ plugins/isoworld/MapSection.h 2014-09-09 12:12:36.000000000 +0200
@@ -32,7 +32,7 @@
  void pointToSprite(float *inx, float *iny, int inz);
  void load_heights(ALLEGRO_BITMAP * heightmap);
  void load_water_level(ALLEGRO_BITMAP * watermap);
- void MapSection::load_colors(s_maplist * map_list);
+ void load_colors(s_maplist * map_list);
  void load_level(ALLEGRO_BITMAP * levelmap, int level);
  void load_biome_tiles(s_maplist * maplist);
  void load_structure_tiles(ALLEGRO_BITMAP * structuremap);Just save it to a file, say mapsection.patch in dfhack source directory and run patch -p0 <mapsection.patch

[Nopenope]

Thanks for the tip. However the error keeps evolving, even though it does seem to build further:

Spoiler (click to show/hide)

Linking CXX executable isoworld
CMakeFiles/isoworld.dir/UserInterface.cpp.o: In function `TilesetActionListener::actionPerformed(agui::ActionEvent const&)':
UserInterface.cpp:(.text+0x19): undefined reference to `agui::ActionEvent::getSource() const'
UserInterface.cpp:(.text+0x27): undefined reference to `typeinfo for agui::DropDown'
UserInterface.cpp:(.text+0x2c): undefined reference to `typeinfo for agui::Widget'
CMakeFiles/isoworld.dir/UserInterface.cpp.o: In function `ConnectActionListener::actionPerformed(agui::ActionEvent const&)':
UserInterface.cpp:(.text+0x68): undefined reference to `agui::ActionEvent::getSource() const'
CMakeFiles/isoworld.dir/UserInterface.cpp.o: In function `initializeAgui()':
UserInterface.cpp:(.text+0xa2): undefined reference to `vtable for agui::Allegro5ImageLoader'
UserInterface.cpp:(.text+0xaa): undefined reference to `agui::Image::setImageLoader(agui::ImageLoader*)'
UserInterface.cpp:(.text+0xbc): undefined reference to `vtable for agui::Allegro5FontLoader'
UserInterface.cpp:(.text+0xc4): undefined reference to `agui::Font::setFontLoader(agui::FontLoader*)'
UserInterface.cpp:(.text+0xda): undefined reference to `agui::Allegro5Input::Allegro5Input()'
UserInterface.cpp:(.text+0xf2): undefined reference to `vtable for agui::Graphics'
UserInterface.cpp:(.text+0x277): undefined reference to `agui::Rectangle::Rectangle()'
UserInterface.cpp:(.text+0x282): undefined reference to `agui::Rectangle::Rectangle()'
UserInterface.cpp:(.text+0x28d): undefined reference to `agui::Point::Point()'
UserInterface.cpp:(.text+0x293): undefined reference to `vtable for agui::Allegro5Graphics'
UserInterface.cpp:(.text+0x2a5): undefined reference to `agui::Color::setPremultiplyAlpha(bool)'
UserInterface.cpp:(.text+0x2bb): undefined reference to `agui::Gui::Gui()'
UserInterface.cpp:(.text+0x2cf): undefined reference to `agui::Gui::setInput(agui::Input*)'
UserInterface.cpp:(.text+0x2e5): undefined reference to `agui::Gui::setGraphics(agui::Graphics*)'
UserInterface.cpp:(.text+0x2f0): undefined reference to `agui::Color::Color()'
UserInterface.cpp:(.text+0x31d): undefined reference to `agui::Font::load(std::string const&, int, agui::FontFlags, float, agui::Color)'
UserInterface.cpp:(.text+0x33c): undefined reference to `agui::Widget::setGlobalFont(agui::Font const*)'
CMakeFiles/isoworld.dir/UserInterface.cpp.o: In function `MainScreen::UpdateText()':
UserInterface.cpp:(.text+0x42e): undefined reference to `agui::Button::setText(std::string const&)'
UserInterface.cpp:(.text+0x481): undefined reference to `agui::Button::setText(std::string const&)'
UserInterface.cpp:(.text+0x4d0): undefined reference to `agui::Button::setText(std::string const&)'
UserInterface.cpp:(.text+0x4fd): undefined reference to `agui::Button::setText(std::string const&)'
CMakeFiles/isoworld.dir/UserInterface.cpp.o: In function `render_gui()':
UserInterface.cpp:(.text+0x611): undefined reference to `agui::Button::setText(std::string const&)'
CMakeFiles/isoworld.dir/UserInterface.cpp.o:UserInterface.cpp:(.text+0x664): more undefined references to `agui::Button::setText(std::string const&)' follow
CMakeFiles/isoworld.dir/UserInterface.cpp.o: In function `render_gui()':
UserInterface.cpp:(.text+0x691): undefined reference to `agui::Gui::render()'
UserInterface.cpp:(.text+0x6c0): undefined reference to `agui::Button::setText(std::string const&)'
UserInterface.cpp:(.text+0x6ed): undefined reference to `agui::Button::setText(std::string const&)'
CMakeFiles/isoworld.dir/UserInterface.cpp.o: In function `MainScreen::MainScreen(agui::Gui*)':
UserInterface.cpp:(.text+0x7d7): undefined reference to `agui::Button::Button()'
UserInterface.cpp:(.text+0x7e8): undefined reference to `agui::Button::Button()'
UserInterface.cpp:(.text+0x7f9): undefined reference to `agui::Button::Button()'
UserInterface.cpp:(.text+0x80c): undefined reference to `agui::DropDown::DropDown(agui::ListBox*)'
UserInterface.cpp:(.text+0x81f): undefined reference to `agui::FlowLayout::FlowLayout()'
UserInterface.cpp:(.text+0x830): undefined reference to `agui::ActionListener::ActionListener()'
UserInterface.cpp:(.text+0x84b): undefined reference to `agui::ActionListener::ActionListener()'
UserInterface.cpp:(.text+0x866): undefined reference to `agui::ActionListener::ActionListener()'
UserInterface.cpp:(.text+0x881): undefined reference to `agui::ActionListener::ActionListener()'
UserInterface.cpp:(.text+0x89a): undefined reference to `agui::Gui::add(agui::Widget*)'
UserInterface.cpp:(.text+0x8a6): undefined reference to `agui::Layout::add(agui::Widget*)'
UserInterface.cpp:(.text+0x8b5): undefined reference to `agui::Button::setSize(int, int)'
UserInterface.cpp:(.text+0x8d3): undefined reference to `agui::Button::setText(std::string const&)'
UserInterface.cpp:(.text+0x8f6): undefined reference to `agui::Widget::addActionListener(agui::ActionListener*)'
UserInterface.cpp:(.text+0x904): undefined reference to `agui::Layout::add(agui::Widget*)'
UserInterface.cpp:(.text+0x911): undefined reference to `agui::Button::setSize(int, int)'
UserInterface.cpp:(.text+0x92f): undefined reference to `agui::Button::setText(std::string const&)'
UserInterface.cpp:(.text+0x952): undefined reference to `agui::Widget::addActionListener(agui::ActionListener*)'
UserInterface.cpp:(.text+0x960): undefined reference to `agui::Layout::add(agui::Widget*)'
UserInterface.cpp:(.text+0x96d): undefined reference to `agui::Button::setSize(int, int)'
UserInterface.cpp:(.text+0x98b): undefined reference to `agui::Button::setText(std::string const&)'
UserInterface.cpp:(.text+0x9ae): undefined reference to `agui::Widget::addActionListener(agui::ActionListener*)'
UserInterface.cpp:(.text+0x9bc): undefined reference to `agui::Layout::add(agui::Widget*)'
UserInterface.cpp:(.text+0x9c9): undefined reference to `agui::DropDown::setSize(int, int)'
UserInterface.cpp:(.text+0x9e4): undefined reference to `agui::Widget::setText(std::string const&)'
UserInterface.cpp:(.text+0xa08): undefined reference to `agui::Widget::addActionListener(agui::ActionListener*)'
UserInterface.cpp:(.text+0xa12): undefined reference to `agui::DropDown::setResizeToWidestItem(bool)'
UserInterface.cpp:(.text+0xb62): undefined reference to `agui::ActionListener::~ActionListener()'
UserInterface.cpp:(.text+0xb7a): undefined reference to `agui::ActionListener::~ActionListener()'
UserInterface.cpp:(.text+0xb92): undefined reference to `agui::ActionListener::~ActionListener()'
UserInterface.cpp:(.text+0xbac): undefined reference to `agui::ActionListener::~ActionListener()'
UserInterface.cpp:(.text+0xbba): undefined reference to `agui::FlowLayout::~FlowLayout()'
UserInterface.cpp:(.text+0xbc8): undefined reference to `agui::DropDown::~DropDown()'
UserInterface.cpp:(.text+0xbd6): undefined reference to `agui::Button::~Button()'
UserInterface.cpp:(.text+0xbe4): undefined reference to `agui::Button::~Button()'
UserInterface.cpp:(.text+0xbf2): undefined reference to `agui::Button::~Button()'
CMakeFiles/isoworld.dir/UserInterface.cpp.o: In function `cleanup_gui()':
UserInterface.cpp:(.text+0xced): undefined reference to `agui::Gui::getTop() const'
UserInterface.cpp:(.text+0xd1f): undefined reference to `agui::ActionListener::~ActionListener()'
UserInterface.cpp:(.text+0xd37): undefined reference to `agui::ActionListener::~ActionListener()'
UserInterface.cpp:(.text+0xd4f): undefined reference to `agui::ActionListener::~ActionListener()'
UserInterface.cpp:(.text+0xd67): undefined reference to `agui::ActionListener::~ActionListener()'
UserInterface.cpp:(.text+0xd75): undefined reference to `agui::FlowLayout::~FlowLayout()'
UserInterface.cpp:(.text+0xd83): undefined reference to `agui::DropDown::~DropDown()'
UserInterface.cpp:(.text+0xd91): undefined reference to `agui::Button::~Button()'
UserInterface.cpp:(.text+0xd9f): undefined reference to `agui::Button::~Button()'
UserInterface.cpp:(.text+0xdaa): undefined reference to `agui::Button::~Button()'
UserInterface.cpp:(.text+0xe16): undefined reference to `vtable for agui::Graphics'
CMakeFiles/isoworld.dir/UserInterface.cpp.o: In function `MainScreen::UpdateTilesetList(MapSection*)':
UserInterface.cpp:(.text+0xef3): undefined reference to `agui::DropDown::addItem(std::string const&)'
UserInterface.cpp:(.text+0xf17): undefined reference to `agui::DropDown::setSelectedIndex(int)'
CMakeFiles/isoworld.dir/UserInterface.cpp.o: In function `FollowActionListener::~FollowActionListener()':
UserInterface.cpp:(.text._ZN20FollowActionListenerD2Ev[_ZN20FollowActionListenerD5Ev]+0xb): undefined reference to `agui::ActionListener::~ActionListener()'
CMakeFiles/isoworld.dir/UserInterface.cpp.o: In function `TilesetActionListener::~TilesetActionListener()':
UserInterface.cpp:(.text._ZN21TilesetActionListenerD2Ev[_ZN21TilesetActionListenerD5Ev]+0xb): undefined reference to `agui::ActionListener::~ActionListener()'
CMakeFiles/isoworld.dir/UserInterface.cpp.o: In function `LoadActionListener::~LoadActionListener()':
UserInterface.cpp:(.text._ZN18LoadActionListenerD2Ev[_ZN18LoadActionListenerD5Ev]+0xb): undefined reference to `agui::ActionListener::~ActionListener()'
CMakeFiles/isoworld.dir/UserInterface.cpp.o: In function `ConnectActionListener::~ConnectActionListener()':
UserInterface.cpp:(.text._ZN21ConnectActionListenerD2Ev[_ZN21ConnectActionListenerD5Ev]+0xb): undefined reference to `agui::ActionListener::~ActionListener()'
CMakeFiles/isoworld.dir/UserInterface.cpp.o: In function `FollowActionListener::~FollowActionListener()':
UserInterface.cpp:(.text._ZN20FollowActionListenerD0Ev[_ZN20FollowActionListenerD5Ev]+0x10): undefined reference to `agui::ActionListener::~ActionListener()'
CMakeFiles/isoworld.dir/UserInterface.cpp.o:UserInterface.cpp:(.text._ZN21TilesetActionListenerD0Ev[_ZN21TilesetActionListenerD5Ev]+0x10): more undefined references to `agui::ActionListener::~ActionListener()' follow
CMakeFiles/isoworld.dir/UserInterface.cpp.o: In function `agui::Allegro5Graphics::~Allegro5Graphics()':
UserInterface.cpp:(.text._ZN4agui16Allegro5GraphicsD0Ev[_ZN4agui16Allegro5GraphicsD5Ev]+0xc): undefined reference to `vtable for agui::Graphics'
CMakeFiles/isoworld.dir/UserInterface.cpp.o: In function `agui::Allegro5Graphics::~Allegro5Graphics()':
UserInterface.cpp:(.text._ZN4agui16Allegro5GraphicsD2Ev[_ZN4agui16Allegro5GraphicsD5Ev]+0xc): undefined reference to `vtable for agui::Graphics'
CMakeFiles/isoworld.dir/UserInterface.cpp.o:(.rodata._ZTI21ConnectActionListener[_ZTI21ConnectActionListener]+0x8): undefined reference to `typeinfo for agui::ActionListener'
CMakeFiles/isoworld.dir/UserInterface.cpp.o:(.rodata._ZTI18LoadActionListener[_ZTI18LoadActionListener]+0x8): undefined reference to `typeinfo for agui::ActionListener'
CMakeFiles/isoworld.dir/UserInterface.cpp.o:(.rodata._ZTI21TilesetActionListener[_ZTI21TilesetActionListener]+0x8): undefined reference to `typeinfo for agui::ActionListener'
CMakeFiles/isoworld.dir/UserInterface.cpp.o:(.rodata._ZTI20FollowActionListener[_ZTI20FollowActionListener]+0x8): undefined reference to `typeinfo for agui::ActionListener'
CMakeFiles/isoworld.dir/main.cpp.o: In function `main':
main.cpp:(.text.startup+0x84f): undefined reference to `agui::Gui::resizeToDisplay()'
collect2: error: ld returned 1 exit status
make[2]: *** [plugins/isoworld/isoworld] Error 1
make[1]: *** [plugins/isoworld/CMakeFiles/isoworld.dir/all] Error 2
make: *** [all] Error 2

[majiin]

The compilation was successful, the linking process failed. You need to modify dfhack/plugins/isoworld/CMakeLists.txt file and add agui to linker. Here is my patch:

Code: [Select]

--- plugins/isoworld/CMakeLists.txt 2014-09-11 19:32:10.998717669 +0200
+++ plugins/isoworld/CMakeLists.txt 2014-08-28 01:18:09.000000000 +0200
@@ -91,6 +92,11 @@
  allegro_image
  allegro_ttf
  ${PROJECT_LIBS}
+ /home/majiin/repos/Agui/build/libagui_allegro5.a
+ /home/majiin/repos/Agui/build/libagui.a
+ )
+ include_directories (
+ /home/majiin/repos/Agui/include
  )
  ENDIF()
  ENDIF()
Of course you need to change /home/majiin/repos/Agui/build/ and /home/majiin/repos/Agui/include to the location where you have those files. Maybe there is a simpler way to do this but this worked for me.

Edit:
You also need to set
STONESENSE_INTERNAL_SO           OFF
when configuring dfhack build so that it will pick system allegro library.
Also the above CMakeLists.txt patch may not be needed if agui/agui-dev is avaliable in your linux distro. Gentoo doesn't have it so I had to compile agui manually and link to it.

[Nopenope]

Thanks, it builds properly now. Now the error is at runtime, it crashes on startup:

Code: [Select]

Starting up log window.
success.
Loading font 'isoworld/DejaVuSans.ttf'...success.
Starting main loop.
*** Error in `./isoworld/isoworld': double free or corruption (out): 0x095d8d30 ***
Aborted (core dumped)
gdb doesn't say much more...I'm probably missing something here.
For information, I made a link from isoworld/isoworld to hack/isoworld since the runisoworld bash script seems to call a program in the wrong place.

Also there's no agui-dev header files in the debian repos as far as I know, I compiled them all (in 32 bit) from https://github.com/jmasterx/Agui

[majiin]

Depending on where make install installs dfhack files - you need to manually copy (at least on Gentoo) executable file from <your build directory>/plugins/isoworld/isoworld to <dfhack install directory>/isoworld/ and run isoworld by starting runisoworld script from dfhack dir. I don't know why executable file isn't copied when you do make install, probably some bug in dfhack cmake build scripts.

Edit:
It seems that dfhack installs isoworld executable into hack directory, not isoworld. Also your error is a bit odd, I don't remember seeing it.

[Nopenope]

Actually it is copied to hack/isoworld and not isoworld/isoworld, so it's simply a wrong path issue I guess. However I still get the above crash on load whenever I run the runisoworld script with the correct path.

[majiin]

You can try and compile dfhack as Debug instead of Release, gdb should provide more useful info, but at this point you should have isoworld up and running, that error message baffles me. Maybe some more experienced programmers can help. Please note that if you're using 64bit compiler you need to add -m32 to c/cxx flags.
If anyone wants, I will make a step-by-step tutorial how I managed to compile a working dfhack+isoworld on Linux Gentoo ~AMD64 with 64bit gcc (it will be different on other distros but still may help)

But first I need to finish my TileStitcher - almost done (today managed to crosscompile windows executable and nailed down some rare stitching bug, need to add few more commandline options). And as promised I'll TRY to add new map naming scheme to IsoWorld.

Example of TileStitcher console output (may change):

Spoiler (click to show/hide)

[majiin@gentoo build]$ ./TileStitcher output.png
Map size: 17x17 (272x272 tiles), filename: output.png, format: RGB + alpha channel
Memory allocated: 1330MiB
Scanning tiles direcory... Done! 19456 tiles found (26.3%)
Stiching tiles... Done!
Saving PNG... Done!

[Nopenope]

Please note that if you're using 64bit compiler you need to add -m32 to c/cxx flags.

Yeah I added the relevant flags when compiling the agui and allegro libs. Also I should note that

Code: [Select]

STONESENSE_INTERNAL_SO           OFF Actually raises a library error (probably because it skips the 64 bit libraries and doesn't find the 32 bit ones) while setting it on doesn't raise anything on build time.

[majiin]

Please note that if you're using 64bit compiler you need to add -m32 to c/cxx flags.

Yeah I added the relevant flags when compiling the agui and allegro libs. Also I should note that

Code: [Select]

STONESENSE_INTERNAL_SO           OFF Actually raises a library error (probably because it skips the 64 bit libraries and doesn't find the 32 bit ones) while setting it on doesn't raise anything on build time.

Well, I get the error when I have this ON, can you share what linux distro are you using? Maybe other linux users could help.