Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[PeridexisErrant]

I'd be willing to work directly with your Legends Processing Suite, but I plan to make a number of changes in the near future which might mess up everything. I'm wondering if we can separate it into multiple files that call each other. Then editing each one would be way easier, and we wouldn't just have one big cluttered file. Besides, as it is it looks like your current suite still has the code from the old version.
Fortunately most of the changes I plan to make will be in the already-standalone GIMP script so that part shouldn't be a problem.

Don't worry about messing up any of my stuff, I can always leave the last stable version up while I try to integrate something completely different.  I can definitely see an argument for splitting up the script - and if the parts go in a subfolder that deals with my main concern about people running the wrong script. 

Personally, one of the issues I had with the Legends Processor was that I didn't really know what it did while (or before) it was running. I also had the unfortunate experience where I had an unrelated file in the folder that contained the string "region2" in the filename, but my only region was region1, so running the processor did nothing but make an empty zip file and delete all my exported data.

I fixed the specific deletion problem earlier today when I spotted it - the OptiPNG section would delete "*egion*.bmp", now changed to "*%region#%*.bmp".  That was an old bit of code... Site maps still have issues as there's no identification of where they come. 

I didn't realize the problem until I read through the code, haha. Something I focused on when writing my .bat file was making sure it gave plenty of instruction and output while running. Given the nature of the Legends Processing Suite, maybe it would be a good idea to prompt the user before each step to ask if they want to continue with or skip that operation too (ex. if I don't want to make a satellite map this time).

Yeah, the documentation is appalling (I tried to comment the script decently, but that's not a substitute).  How much to involve the user is something of a style issue - I should probably do more, but since I started doing it just for me I just assume that the user knows what's happening and wants it to happen quickly.  I'll stick with the 'just make everything' approach, but better documentation and in-progress messages are definitely on the to do list... even calling it with no exports just gives a list of required inputs. 

[CharonM72]

PeridexisErrant, I too am a newbie at the GitHub thing, but it seems I need to have special permissions to push commits to your repository. Could you grant me (also CharonM72 on GitHub) at least write access to the Satellite Map Maker files so I can update them?

[PeridexisErrant]

How do I do that?  And why wouldn't it work to fork/update/pull request?

[CharonM72]

I guess it would work to fork it but then we'd have a bunch of versions of the same thing right? I think we want to keep this centralized if we can.
I don't know how to do pull requests on the Windows platform

EDIT: I can't publish forks either. I need write permissions if I am going to modify or add anything.

[Hugo_The_Dwarf]

is the error:
(gimp-console-2.8.exe:6544): LibGimpBase-WARNING **: gimp-console-2.8.exe: gimp_wire_read(): error

normal? or do I just have an older version of GIMP? also the image does get rendered fine after a few mins, just wanted to know if this error is supposed to happen and if it causes any issues.

[PeridexisErrant]

Not normal (I've never seen it), 2.8 is the latest version, but apparently it still works.

Would you mind testing my script for similar errors? I've reworked a fair bit of the mapmaker section, so it might be different.

[Hugo_The_Dwarf]

Yea I can try and test it right now, or at least very soon.

[CharonM72]

I get a lot of GIMP errors (about installed plugins) when I run GIMP too but it renders fine. It seems GIMP outputs both major and minor errors, so if it works it's nothing to worry about.

[CharonM72]

New version 1.3 released! Mostly under-the-hood stuff, but should make it work a bit more smoothly.

PeridexisErrant, I think for the same of simplicity I'll continue working on this project separately, but feel free to continue to include it in your LNP. I haven't tested it, but the batch file should be callable from another batch file, which means you won't need to integrate it with your script, although it'll have to re-run the GIMP finding and all. By the way SMM uses a slightly modified version of your GIMP finder, since 1. it was taking waaaay too long to find GIMP by just brute-force, and 2. it didn't seem to work anyway. File names shouldn't interfere with anything in your project. Also, you can call the batch file with a parameter at the end that sets the atmosphere level (0-2). Not totally sure if it works though. Feel free to test it and tell me. My project is now also on GitHub so you can follow any changes I make.

[Zorbeltuss]

I just ran the master, version from github and this happened (after the first scriptwindow had said running gimp).

Code: [Select]

(gimp-console-2.8.exe:1848): LibGimpBase-WARNING **: gimp-console-2.8.exe: gimp_
wire_read(): error
batch command experienced an execution error:
Error: ( : 1) eval: unbound variable: \=\"While trying to run the script through gimp I got:

Code: [Select]

Error while executing create-view-satellite:

Error: ( : 1) /: argument 1 must be: numbeIs the script made for a specific size of map or maybe made with a specific span of sizes (I tried the biggest size of map (257x257))? Or is this a bug and where do I report it and how in that case?

/Zorbeltuss

[Hugo_The_Dwarf]

I know the last version 1.2? works fine with the largest map size. If you scroll up I followed the link for PeridexisErrant script combo

Not normal (I've never seen it), 2.8 is the latest version, but apparently it still works.

Would you mind testing my script for similar errors? I've reworked a fair bit of the mapmaker section, so it might be different.

nvm i'll just quote it.
Did you enter a 0, 1, or 2 before it started? it asks for atmosphere level (which I think gives the feeling of fog/clouds)

[Zorbeltuss]

nvm i'll just quote it.
Did you enter a 0, 1, or 2 before it started? it asks for atmosphere level (which I think gives the feeling of fog/clouds)

I will try it now, I tried 0 and 1 in both, and 2 in the bat version, no difference sadly.

Edit: That was the link I followed too apparently

/Zorbeltuss

[PeridexisErrant]

Higher atmosphere gives a stronger pastel blue tint, no cloud effects (yet).

The issue trying to run it through GIMP directly looks like a missing parameter to me, but I can't do any more detail than that.

I think the ffirst error, thrown by the batch script, may be a failure to correctly find the install location - you could try editing it in manually for yourself since you don't have our imperative to general usability.

[Zorbeltuss]

Higher atmosphere gives a stronger pastel blue tint, no cloud effects (yet).

The issue trying to run it through GIMP directly looks like a missing parameter to me, but I can't do any more detail than that.

I think the ffirst error, thrown by the batch script, may be a failure to correctly find the install location - you could try editing it in manually for yourself since you don't have our imperative to general usability.

It was gimp that returned that error too, however I fixed the problem, as a note to later users of this, most things with gimp works right of  the box after installation, but for this to work well it might be an Idea to restart the computer. Also I feel very silly now.

/Zorbeltuss

[CharonM72]

Glad to see the problem was resolved. GIMP is a finicky piece of software; even when I run it it spits out like 15 errors (but it still runs successfully). There shouldn't be any issues with map size or anything as long as all the parameters are specified. Running it through the GIMP GUI should prompt for all the parameters anyway so barring inputting an invalid parameter it should work.

PeridexisErrant's script just calls my script for use anyway, so they should have exactly the same functionality. The only difference would be if he updates something without my knowledge (which would likely break compatibility with my new versions, haha) or if I release a new version and he hasn't updated his with my new files yet.

In a completely unrelated note I am super excited for the next version of DF. It should add a little more data to the exported maps that I can play with.