Bay 12 Games Forum

Please login or register.

Login with username, password and session length
Advanced search  
Pages: 1 ... 21 22 [23] 24 25

Author Topic: National LCS Revisited (4.07.4 Beta Release!)  (Read 108084 times)

EuchreJack

  • Bay Watcher
  • Lord of Norderland - Lv 20 SKOOKUM ROC
    • View Profile
Re: National LCS Revisited (4.07.4 Beta Release!)
« Reply #330 on: February 14, 2014, 06:05:19 pm »

I'm not getting any juice at all from community service.
I had a character with 0 juice work there for 1 month and still not a single point of juice was gained.

Community service only increases your juice to 0. It's for the "lower" class Liberals who have negative juice.

Most importantly, it decreases heat.  Quite effectively too.  I think the liberal generating heat has to do the community service, but I'm not sure.

Thanks, I forgot. Adding more on to it, you can't be arrested while doing it. Minor detail is that it increases public relation giving better profits in donations.
Hm, you can't be arrested while doing community service?  ???  That is a perk, but are you sure?

You're making me doubt myself, but I have never been arrested while doing it before. I've sent nude sweatshop workers, insanely high heat liberals all doing it without having to unload a magazine.

Ok, I believe you, don't worry about it...
*Leader EuchreJack is attacked while doing community service!*   :P

But seriously, my experiences have been the same, so I'm guessing its safe to say that one can't be arrested while doing community service.

SlatersQuest

  • Bay Watcher
    • View Profile
Re: National LCS Revisited (4.07.4 Beta Release!)
« Reply #331 on: February 17, 2014, 11:49:46 pm »

Just checked the code.

The activities are run through the function funds_and_trouble() in activities.cpp. I was able to verify the following:

1. Doing community service does in fact only reduce heat if the person doing community service has heat. Note that it does not matter how much heat, however.

2. Most of the activities have a function at the end of funds_and_trouble() that does the activity in question (soliciting donations, selling brownies, teaching other liberals, etc.). Within these functions is a checkforarrest() function. Because ACTIVITY_COMMUNITYSERVICE does not trigger a function within funds_and_trouble(), there is no way to call checkforarrest(), and therefore no way to get arrested while doing community service (or, for that matter, get ambushed by a mob of hicks either).
Logged

FinetalPies

  • Bay Watcher
  • Even on the battlefield.
    • View Profile
Re: National LCS Revisited (4.07.4 Beta Release!)
« Reply #332 on: February 18, 2014, 11:36:16 am »

Sweet, thanks SlatersQuest. Checkin' the code was cool of you 2 do
Logged

EuchreJack

  • Bay Watcher
  • Lord of Norderland - Lv 20 SKOOKUM ROC
    • View Profile
Re: National LCS Revisited (4.07.4 Beta Release!)
« Reply #333 on: February 19, 2014, 12:53:17 pm »

Thanks SlatersQuest.  I was hoping one of the code divers would confirm the safety of community service.  It's nice to be sure.

Cheedows

  • Bay Watcher
  • Still a dwarf, right?
    • View Profile
Re: National LCS Revisited (4.07.4 Beta Release!)
« Reply #334 on: February 20, 2014, 01:03:38 am »

Well, glad we got that cleared up. The wonders of code-diving.
Logged

Glloyd

  • Bay Watcher
  • Against the Tide
    • View Profile
Re: National LCS Revisited (4.07.4 Beta Release!)
« Reply #335 on: March 17, 2014, 08:13:42 pm »

So has there been any work done on this recently? It`s been far too long since a full release. I need to kill some Conservatives, stat.

Cheedows

  • Bay Watcher
  • Still a dwarf, right?
    • View Profile
Re: National LCS Revisited (4.07.4 Beta Release!)
« Reply #336 on: March 17, 2014, 10:00:08 pm »

You never really know, Curses hasn't exactly been known as the most active board. Fox might be working on something though.
Logged

Fungus

  • Bay Watcher
    • View Profile
Re: National LCS Revisited (4.07.4 Beta Release!)
« Reply #337 on: March 21, 2014, 06:24:34 pm »

I hope someone here can help me out. I'm trying to build the latest version and I'm running into an error. LCS 4.07.6 isn't compiling and I don't see why, but I've only just started out with C++ so that's to be expected. The debugger is breaking with the message that "string subscript is out of range" in line 1440 of visual studio\vc\include\xstring. It seems to be offended by the do while in configfile.cpp, the error points me to the end of that. For clarity:

Code: [Select]
int readLine(std::ifstream& file, std::string& command, std::string& value)
{
   std::string line;
   int source=0;

   // Search for a non-comment, non-empty line
   do
   {
      if(file.eof()) return 0;
      getline(file,line);
      line.erase(std::remove(line.begin(), line.end(), '\r'), line.end());
      line.erase(std::remove(line.begin(), line.end(), '\n'), line.end());
   } while(line[0] == '#' || line[0] == 0);
Any other info needed just ask, I'll provide. And if this should be in its' own topic, let me know via pm, I'll delete and repost.
Logged

Carlos Gustavos

  • Bay Watcher
    • View Profile
Re: National LCS Revisited (4.07.4 Beta Release!)
« Reply #338 on: March 22, 2014, 09:43:27 am »

The code uses a feature of std::string where if you use the index operator with a value equal to the size of the string, then it will return a null character as if the string was null-terminated. The code uses this to test if it has reached the end of the string. Microsoft's implementation of C++ only allows this for constant strings so if you do a debug build it will tell you you're doing it wrong.
Logged

Fungus

  • Bay Watcher
    • View Profile
Re: National LCS Revisited (4.07.4 Beta Release!)
« Reply #339 on: March 22, 2014, 10:26:03 am »

Gah, thanks, though I'm afraid I wouldn't know where to start with fixing that! How did it even compile in the first place? But now I know what the problem is I can start looking into workarounds.
Logged

Carlos Gustavos

  • Bay Watcher
    • View Profile
Re: National LCS Revisited (4.07.4 Beta Release!)
« Reply #340 on: March 23, 2014, 01:18:45 pm »

I think it might not have been a problem with earlier versions of Visual Studio. Anyway, I've rewritten the checks now.

For anyone wanting the latest in development, you can get a new binary here:
http://sourceforge.net/p/lcsgame/code/HEAD/tree/trunk/workspaces/Debug/

And you'll also have to get creatures.xml from here:
http://sourceforge.net/p/lcsgame/code/HEAD/tree/trunk/art/creatures.xml
Logged

tykavanaugh

  • Bay Watcher
    • View Profile
Re: National LCS Revisited (4.07.4 Beta Release!)
« Reply #341 on: March 28, 2014, 06:35:45 pm »

Has anyone made a stable mac version of the new LCS yet?
Logged

Little

  • Bay Watcher
  • IN SOVIET RUSSIA, LITTLE IS YOU!
    • View Profile
Re: National LCS Revisited (4.07.4 Beta Release!)
« Reply #342 on: April 25, 2014, 05:30:31 am »

Any news on a new release?
Logged
Blizzard is managed by dark sorcerers, and probably have enough money to bail-out the federal government.

SlatersQuest

  • Bay Watcher
    • View Profile
Re: National LCS Revisited (4.07.4 Beta Release!)
« Reply #343 on: April 25, 2014, 08:32:03 am »

The currently working version is pretty stable.
Logged

Little

  • Bay Watcher
  • IN SOVIET RUSSIA, LITTLE IS YOU!
    • View Profile
Re: National LCS Revisited (4.07.4 Beta Release!)
« Reply #344 on: April 25, 2014, 01:04:41 pm »

The currently working version is pretty stable.

Well aware, just hoping for new features to be not too far away :p :)
Logged
Blizzard is managed by dark sorcerers, and probably have enough money to bail-out the federal government.
Pages: 1 ... 21 22 [23] 24 25